Title: [223554] trunk/LayoutTests
- Revision
- 223554
- Author
- [email protected]
- Date
- 2017-10-17 10:19:24 -0700 (Tue, 17 Oct 2017)
Log Message
De-flakify http/tests/loading/basic-auth-resend-wrong-credentials.html
https://bugs.webkit.org/show_bug.cgi?id=178370
Reviewed by Ryosuke Niwa.
Like r223445, in WebKit2 (and WebKit1 with asynchronous loading) sometimes the iframe would start
loading before the main resource loading finished, sometimes it wouldn't. This isn't a problem,
and the rest of the test is still valid, but in order to make the dumped delegate callbacks deterministic,
we make it so the iframe always starts loading after the main resource is done loading.
* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
* http/tests/loading/basic-auth-resend-wrong-credentials.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (223553 => 223554)
--- trunk/LayoutTests/ChangeLog 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/ChangeLog 2017-10-17 17:19:24 UTC (rev 223554)
@@ -1,3 +1,21 @@
+2017-10-17 Alex Christensen <[email protected]>
+
+ De-flakify http/tests/loading/basic-auth-resend-wrong-credentials.html
+ https://bugs.webkit.org/show_bug.cgi?id=178370
+
+ Reviewed by Ryosuke Niwa.
+
+ Like r223445, in WebKit2 (and WebKit1 with asynchronous loading) sometimes the iframe would start
+ loading before the main resource loading finished, sometimes it wouldn't. This isn't a problem,
+ and the rest of the test is still valid, but in order to make the dumped delegate callbacks deterministic,
+ we make it so the iframe always starts loading after the main resource is done loading.
+
+ * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+ * http/tests/loading/basic-auth-resend-wrong-credentials.html:
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+
2017-10-17 Daniel Bates <[email protected]>
ASSERTION FAILED: m_truncation != cFullTruncation in InlineTextBox::clampedOffset()
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (223553 => 223554)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-17 17:19:24 UTC (rev 223554)
@@ -1,7 +1,8 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,12 +13,11 @@
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
main frame - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
-
+
--------
Frame: '<!--framePath //<!--frame0-->-->'
--------
Modified: trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html (223553 => 223554)
--- trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html 2017-10-17 17:19:24 UTC (rev 223554)
@@ -27,10 +27,16 @@
testRunner.notifyDone();
}
+function makeIFrame() {
+ var iframe = document.createElement("iframe");
+ iframe._onload_=firstFrameLoaded;
+ iframe.src=""
+ document.body.appendChild(iframe);
+}
+
</script>
</head>
-<body>
+<body _onload_="makeIFrame()">
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.<br>
-<iframe src="" _onload_="firstFrameLoaded();"></iframe>
</body>
</html>
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (223553 => 223554)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-10-17 17:19:24 UTC (rev 223554)
@@ -1856,8 +1856,6 @@
webkit.org/b/159840 http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Pass Timeout ]
-webkit.org/b/159884 [ Debug ] http/tests/loading/basic-auth-resend-wrong-credentials.html [ Pass Failure ]
-
webkit.org/b/159881 [ Release ] fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html [ Pass ImageOnlyFailure ]
webkit.org/b/160368 http/tests/xmlhttprequest/workers/methods-async.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (223553 => 223554)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-10-17 17:19:24 UTC (rev 223554)
@@ -619,8 +619,6 @@
webkit.org/b/167607 [ Debug ] http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html [ Pass Timeout ]
-webkit.org/b/159884 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Pass Failure ]
-
webkit.org/b/159896 storage/indexeddb/modern/handle-user-delete.html [ Pass Timeout ]
webkit.org/b/160042 accessibility/mac/value-change/value-change-user-info-contenteditable.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt (223553 => 223554)
--- trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-17 17:13:56 UTC (rev 223553)
+++ trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt 2017-10-17 17:19:24 UTC (rev 223554)
@@ -1,7 +1,8 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,12 +13,11 @@
frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
main frame - didFinishLoadForFrame
This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
-
+
--------
Frame: '<!--framePath //<!--frame0-->-->'
--------
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
