Title: [223555] trunk/LayoutTests
- Revision
- 223555
- Author
- achristen...@apple.com
- Date
- 2017-10-17 10:37:10 -0700 (Tue, 17 Oct 2017)
Log Message
Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=150095
Reviewed by Tim Horton.
* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt:
* http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html:
* platform/mac-wk2/TestExpectations:
We were mixing jsTestIsAsync with testRunner.notifyDone which caused some flakiness.
Calling finishJSTest on the next runloop iteration causes it to no longer be flaky.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (223554 => 223555)
--- trunk/LayoutTests/ChangeLog 2017-10-17 17:19:24 UTC (rev 223554)
+++ trunk/LayoutTests/ChangeLog 2017-10-17 17:37:10 UTC (rev 223555)
@@ -1,5 +1,18 @@
2017-10-17 Alex Christensen <achristen...@webkit.org>
+ Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=150095
+
+ Reviewed by Tim Horton.
+
+ * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt:
+ * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html:
+ * platform/mac-wk2/TestExpectations:
+ We were mixing jsTestIsAsync with testRunner.notifyDone which caused some flakiness.
+ Calling finishJSTest on the next runloop iteration causes it to no longer be flaky.
+
+2017-10-17 Alex Christensen <achristen...@webkit.org>
+
De-flakify http/tests/loading/basic-auth-resend-wrong-credentials.html
https://bugs.webkit.org/show_bug.cgi?id=178370
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt (223554 => 223555)
--- trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt 2017-10-17 17:19:24 UTC (rev 223554)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt 2017-10-17 17:37:10 UTC (rev 223555)
@@ -14,4 +14,7 @@
PASS req.overrideMimeType("text/plain") threw exception InvalidStateError: The object is in an invalid state..
Testing overrideMimeType when readyState = 4
PASS req.overrideMimeType("text/plain") threw exception InvalidStateError: The object is in an invalid state..
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html (223554 => 223555)
--- trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html 2017-10-17 17:19:24 UTC (rev 223554)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html 2017-10-17 17:37:10 UTC (rev 223555)
@@ -25,10 +25,8 @@
shouldNotThrow('req.overrideMimeType("text/plain")');
}
- if (req.readyState == req.DONE) {
- if (window.testRunner)
- testRunner.notifyDone();
- }
+ if (req.readyState == req.DONE)
+ setTimeout(finishJSTest, 0);
}
function runTest(type) {
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (223554 => 223555)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-10-17 17:19:24 UTC (rev 223554)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-10-17 17:37:10 UTC (rev 223555)
@@ -332,10 +332,6 @@
webkit.org/b/147075 [ Debug ] http/tests/cache/disk-cache/disk-cache-disable.html [ Pass Failure Timeout ]
webkit.org/b/149087 [ Debug ] http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Pass Failure Timeout ]
-
-
-webkit.org/b/150095 http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html [ Pass Timeout ]
-
webkit.org/b/150241 webarchive/loading/object.html [ Pass Crash ]
webkit.org/b/150942 animations/multiple-backgrounds.html [ Pass ImageOnlyFailure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
