Title: [226376] trunk/Tools
- Revision
- 226376
- Author
- mcatanz...@igalia.com
- Date
- 2018-01-03 16:32:37 -0800 (Wed, 03 Jan 2018)
Log Message
REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=173915
Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
/webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
empty string in this case.
* TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(emitFormSubmissionEvent):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (226375 => 226376)
--- trunk/Tools/ChangeLog 2018-01-03 23:52:03 UTC (rev 226375)
+++ trunk/Tools/ChangeLog 2018-01-04 00:32:37 UTC (rev 226376)
@@ -1,5 +1,18 @@
2018-01-03 Michael Catanzaro <mcatanz...@igalia.com>
+ REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
+ https://bugs.webkit.org/show_bug.cgi?id=173915
+
+ Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
+ /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
+ GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
+ empty string in this case.
+
+ * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
+ (emitFormSubmissionEvent):
+
+2018-01-03 Michael Catanzaro <mcatanz...@igalia.com>
+
[GTK] Add web process API to detect when form is submitted via _javascript_
https://bugs.webkit.org/show_bug.cgi?id=173915
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp (226375 => 226376)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp 2018-01-03 23:52:03 UTC (rev 226375)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp 2018-01-04 00:32:37 UTC (rev 226376)
@@ -349,7 +349,7 @@
"/org/webkit/gtk/WebExtensionTest",
"org.webkit.gtk.WebExtensionTest",
methodName,
- g_variant_new("(sssbb)", formID, names, values, targetFrameIsMainFrame, sourceFrameIsMainFrame),
+ g_variant_new("(sssbb)", formID ? formID : "", names, values, targetFrameIsMainFrame, sourceFrameIsMainFrame),
nullptr);
g_assert(ok);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
