Title: [226378] trunk/Tools
- Revision
- 226378
- Author
- simon.fra...@apple.com
- Date
- 2018-01-03 16:42:21 -0800 (Wed, 03 Jan 2018)
Log Message
filter-build-webkit filters out useful compiler error lines
https://bugs.webkit.org/show_bug.cgi?id=179864
Reviewed by Tim Horton.
Don't filter out lines that contain information about build errors by always showing lines
after a line that contains "note:" or "error:".
* Scripts/filter-build-webkit:
(shouldShowSubsequentLine):
(shouldIgnoreLine):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (226377 => 226378)
--- trunk/Tools/ChangeLog 2018-01-04 00:32:57 UTC (rev 226377)
+++ trunk/Tools/ChangeLog 2018-01-04 00:42:21 UTC (rev 226378)
@@ -1,3 +1,17 @@
+2018-01-03 Simon Fraser <simon.fra...@apple.com>
+
+ filter-build-webkit filters out useful compiler error lines
+ https://bugs.webkit.org/show_bug.cgi?id=179864
+
+ Reviewed by Tim Horton.
+
+ Don't filter out lines that contain information about build errors by always showing lines
+ after a line that contains "note:" or "error:".
+
+ * Scripts/filter-build-webkit:
+ (shouldShowSubsequentLine):
+ (shouldIgnoreLine):
+
2018-01-03 Michael Catanzaro <mcatanz...@igalia.com>
REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
Modified: trunk/Tools/Scripts/filter-build-webkit (226377 => 226378)
--- trunk/Tools/Scripts/filter-build-webkit 2018-01-04 00:32:57 UTC (rev 226377)
+++ trunk/Tools/Scripts/filter-build-webkit 2018-01-04 00:42:21 UTC (rev 226378)
@@ -229,6 +229,16 @@
$outputFormat = $value;
}
+sub shouldShowSubsequentLine($)
+{
+ my ($line) = @_;
+
+ return 1 if $line =~ /referenced from:$/;
+ return 1 if $line =~ /(note:|error:)/;
+
+ return 0;
+}
+
sub shouldIgnoreLine($$)
{
my ($previousLine, $line) = @_;
@@ -281,7 +291,7 @@
return 1 if $line =~ /which.exe bash/;
} else {
return 1 if $line =~ /^(touch|perl|cat|rm -f|bison|flex|python|\/usr\/bin\/g\+\+|\/bin\/ln|gperf|echo|sed|if \[ \-f|WebCore\/generate-export-file|write-file|chmod) /;
- return 1 if $line =~ /^ / && $previousLine !~ /referenced from:$/;
+ return 1 if $line =~ /^ / && !shouldShowSubsequentLine($previousLine);
return 1 if $line =~ /^printf /;
return 1 if $line =~ /^offlineasm: Nothing changed/;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
