Title: [227125] trunk/Websites/perf.webkit.org
- Revision
- 227125
- Author
- [email protected]
- Date
- 2018-01-17 22:45:31 -0800 (Wed, 17 Jan 2018)
Log Message
Unreviewed build fixes in TestGroupResultsViewer.
* public/v3/components/test-group-results-viewer.js:
(TestGroupResultsViewer.prototype.render): _renderCurrentMetricsLazily was never called.
(TestGroupResultsViewer.prototype._buildRowForMetric): Don't try to render null or NaN.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (227124 => 227125)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-01-18 06:17:48 UTC (rev 227124)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-01-18 06:45:31 UTC (rev 227125)
@@ -1,5 +1,13 @@
2018-01-17 Ryosuke Niwa <[email protected]>
+ Unreviewed build fixes in TestGroupResultsViewer.
+
+ * public/v3/components/test-group-results-viewer.js:
+ (TestGroupResultsViewer.prototype.render): _renderCurrentMetricsLazily was never called.
+ (TestGroupResultsViewer.prototype._buildRowForMetric): Don't try to render null or NaN.
+
+2018-01-17 Ryosuke Niwa <[email protected]>
+
Fix perf dashboard tests for node v8
https://bugs.webkit.org/show_bug.cgi?id=181782
Modified: trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-viewer.js (227124 => 227125)
--- trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-viewer.js 2018-01-18 06:17:48 UTC (rev 227124)
+++ trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-viewer.js 2018-01-18 06:45:31 UTC (rev 227125)
@@ -40,6 +40,7 @@
this._renderResultsTableLazily.evaluate(this._testGroup, this._expandedTests,
...this._analysisResults.topLevelTestsForTestGroup(this._testGroup));
+ this._renderCurrentMetricsLazily.evaluate(this._currentMetric);
}
_renderResultsTable(testGroup, expandedTests, ...tests)
@@ -99,7 +100,10 @@
const deltaFormatter = metric.makeFormatter(2, false);
const formatValue = (value, interval) => {
const delta = interval ? (interval[1] - interval[0]) / 2 : null;
- return value == null || isNaN(value) ? '-' : `${formatter(value)} \u00b1 ${deltaFormatter(delta)}`;
+ let result = value == null || isNaN(value) ? '-' : formatter(value);
+ if (delta != null && !isNaN(delta))
+ result += ` \u00b1 ${deltaFormatter(delta)}`;
+ return result;
}
const barGroup = new BarGraphGroup();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
