Title: [227126] trunk/Tools
- Revision
- 227126
- Author
- [email protected]
- Date
- 2018-01-17 22:50:12 -0800 (Wed, 17 Jan 2018)
Log Message
[GTK][WPE] Show unit tests unexpectedly passing in the bots
https://bugs.webkit.org/show_bug.cgi?id=181726
Reviewed by Michael Catanzaro.
Now that we have the info, let's show it also in the bots.
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunGLibAPITests.commandComplete):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (227125 => 227126)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-01-18 06:45:31 UTC (rev 227125)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-01-18 06:50:12 UTC (rev 227126)
@@ -628,28 +628,35 @@
logText = cmd.logs['stdio'].getText()
- self.incorrectTests = 0
- self.crashedTests = 0
- self.timedOutTests = 0
- self.skippedTests = 0
+ failedTests = 0
+ crashedTests = 0
+ timedOutTests = 0
+ messages = []
self.statusLine = []
foundItems = re.findall("Unexpected failures \((\d+)\)", logText)
- if (foundItems):
- self.incorrectTests = int(foundItems[0])
+ if foundItems:
+ failedTests = int(foundItems[0])
+ messages.append("%d failures" % failedTests)
foundItems = re.findall("Unexpected crashes \((\d+)\)", logText)
- if (foundItems):
- self.crashedTests = int(foundItems[0])
+ if foundItems:
+ crashedTests = int(foundItems[0])
+ messages.append("%d crashes" % crashedTests)
foundItems = re.findall("Unexpected timeouts \((\d+)\)", logText)
- if (foundItems):
- self.timedOutTests = int(foundItems[0])
+ if foundItems:
+ timedOutTests = int(foundItems[0])
+ messages.append("%d timeouts" % timedOutTests)
- self.totalFailedTests = self.incorrectTests + self.crashedTests + self.timedOutTests
+ foundItems = re.findall("Unexpected passes \((\d+)\)", logText)
+ if foundItems:
+ newPassTests = int(foundItems[0])
+ messages.append("%d new passes" % newPassTests)
- if self.totalFailedTests > 0:
- self.statusLine = ["%d API tests failed, %d crashed, %d timed out" % (self.incorrectTests, self.crashedTests, self.timedOutTests)]
+ self.totalFailedTests = failedTests + crashedTests + timedOutTests
+ if messages:
+ self.statusLine = ["API tests: %s" % ", ".join(messages)]
def evaluateCommand(self, cmd):
if self.totalFailedTests > 0:
Modified: trunk/Tools/ChangeLog (227125 => 227126)
--- trunk/Tools/ChangeLog 2018-01-18 06:45:31 UTC (rev 227125)
+++ trunk/Tools/ChangeLog 2018-01-18 06:50:12 UTC (rev 227126)
@@ -1,3 +1,15 @@
+2018-01-17 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] Show unit tests unexpectedly passing in the bots
+ https://bugs.webkit.org/show_bug.cgi?id=181726
+
+ Reviewed by Michael Catanzaro.
+
+ Now that we have the info, let's show it also in the bots.
+
+ * BuildSlaveSupport/build.webkit.org-config/steps.py:
+ (RunGLibAPITests.commandComplete):
+
2018-01-17 Ling Ho <[email protected]>
Fix broken unittest after r227048
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
