Title: [227616] trunk/Tools
- Revision
- 227616
- Author
- [email protected]
- Date
- 2018-01-25 11:27:32 -0800 (Thu, 25 Jan 2018)
Log Message
REGRESSION(r227457): Release assert in updateLayout while destructing a media element
https://bugs.webkit.org/show_bug.cgi?id=182038
<rdar://problem/36812083>
Reviewed by Jer Noble.
* TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
(TestWebKitAPI::TEST): Show/hide page so controls are always updated.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (227615 => 227616)
--- trunk/Tools/ChangeLog 2018-01-25 18:48:02 UTC (rev 227615)
+++ trunk/Tools/ChangeLog 2018-01-25 19:27:32 UTC (rev 227616)
@@ -1,3 +1,14 @@
+2018-01-25 Eric Carlson <[email protected]>
+
+ REGRESSION(r227457): Release assert in updateLayout while destructing a media element
+ https://bugs.webkit.org/show_bug.cgi?id=182038
+ <rdar://problem/36812083>
+
+ Reviewed by Jer Noble.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
+ (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
+
2018-01-24 Daniel Bates <[email protected]>
webkit-patch upload emits irrelevant simulator warnings
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm (227615 => 227616)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm 2018-01-25 18:48:02 UTC (rev 227615)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm 2018-01-25 19:27:32 UTC (rev 227616)
@@ -99,6 +99,10 @@
[webView loadTestPageNamed:@"large-video-test-now-playing"];
[webView waitForMessage:@"playing"];
+ [webView setWindowVisible:NO];
+ [webView.get().window resignKeyWindow];
+ [webView expectHasActiveNowPlayingSession:YES];
+
[webView setWindowVisible:YES];
[webView.get().window makeKeyWindow];
[webView expectHasActiveNowPlayingSession:NO];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
