Title: [227618] trunk/Source/WebKit
- Revision
- 227618
- Author
- [email protected]
- Date
- 2018-01-25 11:34:48 -0800 (Thu, 25 Jan 2018)
Log Message
[Mac] Enable library validation for Networking & Storage XPC services
https://bugs.webkit.org/show_bug.cgi?id=173424
<rdar://problem/32386565>
Reviewed by Joseph Pecoraro.
* Configurations/BaseXPCService.xcconfig: Moved the definitions of
WK_LIBRARY_VALIDATION_ENABLED and WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS from
WebContentService.xcconfig to here and made them Mac-only at this level.
* Configurations/NetworkService.xcconfig: Also set OTHER_CODE_SIGN_FLAGS to
WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS.
* Configurations/StorageService.xcconfig: Ditto.
* Configurations/WebContentService.xcconfig: Moved definitions from here to
BaseXPCService.xcconfig.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227617 => 227618)
--- trunk/Source/WebKit/ChangeLog 2018-01-25 19:32:00 UTC (rev 227617)
+++ trunk/Source/WebKit/ChangeLog 2018-01-25 19:34:48 UTC (rev 227618)
@@ -1,3 +1,20 @@
+2018-01-25 Dan Bernstein <[email protected]>
+
+ [Mac] Enable library validation for Networking & Storage XPC services
+ https://bugs.webkit.org/show_bug.cgi?id=173424
+ <rdar://problem/32386565>
+
+ Reviewed by Joseph Pecoraro.
+
+ * Configurations/BaseXPCService.xcconfig: Moved the definitions of
+ WK_LIBRARY_VALIDATION_ENABLED and WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS from
+ WebContentService.xcconfig to here and made them Mac-only at this level.
+ * Configurations/NetworkService.xcconfig: Also set OTHER_CODE_SIGN_FLAGS to
+ WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS.
+ * Configurations/StorageService.xcconfig: Ditto.
+ * Configurations/WebContentService.xcconfig: Moved definitions from here to
+ BaseXPCService.xcconfig.
+
2018-01-25 David Hyatt <[email protected]>
Enable lines clamp support for Apple Mail by default
Modified: trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig (227617 => 227618)
--- trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig 2018-01-25 19:32:00 UTC (rev 227617)
+++ trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig 2018-01-25 19:34:48 UTC (rev 227618)
@@ -67,3 +67,13 @@
WK_XPC_SERVICE_INSERT_LIBRARIES_DIR_ = $(WK_XPC_SERVICE_INSERT_LIBRARIES_DIR_NO);
WK_XPC_SERVICE_INSERT_LIBRARIES_DIR_NO = $(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/Frameworks;
WK_XPC_SERVICE_INSERT_LIBRARIES_DIR_YES = @executable_path/$(WK_PATH_FROM_SERVICE_EXECUTABLE_TO_FRAMEWORK)/Frameworks;
+
+WK_LIBRARY_VALIDATION_ENABLED = $(WK_LIBRARY_VALIDATION_ENABLED_$(WK_EMPTY_$(WK_LIBRARY_VALIDATION_ENABLED)));
+WK_LIBRARY_VALIDATION_ENABLED_ = $(WK_LIBRARY_VALIDATION_ENABLED_NO);
+WK_LIBRARY_VALIDATION_ENABLED_NO = $(WK_LIBRARY_VALIDATION_ENABLED);
+WK_LIBRARY_VALIDATION_ENABLED_YES = YES;
+
+WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS[sdk=macosx*] = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_$(WK_XPC_SERVICE_VARIANT));
+WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_ = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_Normal);
+WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_Normal = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_$(WK_LIBRARY_VALIDATION_ENABLED));
+WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_YES = -o library;
Modified: trunk/Source/WebKit/Configurations/NetworkService.xcconfig (227617 => 227618)
--- trunk/Source/WebKit/Configurations/NetworkService.xcconfig 2018-01-25 19:32:00 UTC (rev 227617)
+++ trunk/Source/WebKit/Configurations/NetworkService.xcconfig 2018-01-25 19:34:48 UTC (rev 227618)
@@ -25,6 +25,8 @@
WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE = Network-iOS;
+OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);
+
PRODUCT_NAME = com.apple.WebKit.Networking;
PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
INFOPLIST_FILE[sdk=iphone*] = NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist;
Modified: trunk/Source/WebKit/Configurations/StorageService.xcconfig (227617 => 227618)
--- trunk/Source/WebKit/Configurations/StorageService.xcconfig 2018-01-25 19:32:00 UTC (rev 227617)
+++ trunk/Source/WebKit/Configurations/StorageService.xcconfig 2018-01-25 19:34:48 UTC (rev 227618)
@@ -25,6 +25,8 @@
WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE = Databases-iOS;
+OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);
+
PRODUCT_NAME = $(WK_STORAGE_SERVICE_PRODUCT_NAME);
PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
INFOPLIST_FILE = StorageProcess/EntryPoint/mac/XPCService/StorageService/Info.plist;
Modified: trunk/Source/WebKit/Configurations/WebContentService.xcconfig (227617 => 227618)
--- trunk/Source/WebKit/Configurations/WebContentService.xcconfig 2018-01-25 19:32:00 UTC (rev 227617)
+++ trunk/Source/WebKit/Configurations/WebContentService.xcconfig 2018-01-25 19:34:48 UTC (rev 227618)
@@ -27,7 +27,7 @@
CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = $(CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_$(WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT));
CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_YES = Configurations/WebContent-OSX.entitlements;
-OTHER_CODE_SIGN_FLAGS[sdk=macosx*] = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);
+OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);
PRODUCT_NAME = $(PRODUCT_NAME_$(WK_XPC_SERVICE_VARIANT));
PRODUCT_NAME_ = $(PRODUCT_NAME_Normal);
@@ -46,21 +46,11 @@
WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT_NO = $(WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT);
WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT_YES = $(WK_RELOCATABLE_FRAMEWORKS);
-WK_LIBRARY_VALIDATION_ENABLED = $(WK_LIBRARY_VALIDATION_ENABLED_$(WK_EMPTY_$(WK_LIBRARY_VALIDATION_ENABLED)));
-WK_LIBRARY_VALIDATION_ENABLED_ = $(WK_LIBRARY_VALIDATION_ENABLED_NO);
-WK_LIBRARY_VALIDATION_ENABLED_NO = $(WK_LIBRARY_VALIDATION_ENABLED);
-WK_LIBRARY_VALIDATION_ENABLED_YES = YES;
-
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG = $(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_$(WK_EMPTY_$(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG)));
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_ = $(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_NO);
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_NO = $(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG);
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_YES = $(USE_STAGING_INSTALL_PATH);
-WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_$(WK_XPC_SERVICE_VARIANT));
-WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_ = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_Normal);
-WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_Normal = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_$(WK_LIBRARY_VALIDATION_ENABLED));
-WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS_YES = -o library;
-
RUNLOOP_TYPE[sdk=macosx*] = NSRunLoop;
RUNLOOP_TYPE[sdk=macosx10.13*] = _NSApplicationMain;
RUNLOOP_TYPE[sdk=macosx10.12*] = _NSApplicationMain;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
