Title: [227670] trunk/Source/WebKit
- Revision
- 227670
- Author
- [email protected]
- Date
- 2018-01-26 01:18:23 -0800 (Fri, 26 Jan 2018)
Log Message
Unreviewed. REGRESSION(r227647): window.open() is broken in GTK and WPE after r227647.
In r227647, API::UIClient::createNewPage() was changed to use CompletionHandler instead of Function. All
implementations were updated expect the GLib one, and we didn't notice it because the method doesn't have the
final/override mark.
* UIProcess/API/glib/WebKitUIClient.cpp:
(UIClient::createNewPage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (227669 => 227670)
--- trunk/Source/WebKit/ChangeLog 2018-01-26 08:54:17 UTC (rev 227669)
+++ trunk/Source/WebKit/ChangeLog 2018-01-26 09:18:23 UTC (rev 227670)
@@ -1,3 +1,14 @@
+2018-01-26 Carlos Garcia Campos <[email protected]>
+
+ Unreviewed. REGRESSION(r227647): window.open() is broken in GTK and WPE after r227647.
+
+ In r227647, API::UIClient::createNewPage() was changed to use CompletionHandler instead of Function. All
+ implementations were updated expect the GLib one, and we didn't notice it because the method doesn't have the
+ final/override mark.
+
+ * UIProcess/API/glib/WebKitUIClient.cpp:
+ (UIClient::createNewPage):
+
2018-01-25 Sergio Villar Senin <[email protected]>
[WebVR] Make WebVR available by default for developer builds
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (227669 => 227670)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2018-01-26 08:54:17 UTC (rev 227669)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2018-01-26 09:18:23 UTC (rev 227670)
@@ -47,7 +47,7 @@
}
private:
- void createNewPage(WebPageProxy& page, Ref<API::FrameInfo>&& frameInfo, WebCore::ResourceRequest&& resourceRequest, WebCore::WindowFeatures&& windowFeatures, NavigationActionData&& navigationActionData, WTF::Function<void(RefPtr<WebPageProxy>&&)>&& completionHandler)
+ void createNewPage(WebPageProxy& page, Ref<API::FrameInfo>&& frameInfo, WebCore::ResourceRequest&& resourceRequest, WebCore::WindowFeatures&& windowFeatures, NavigationActionData&& navigationActionData, CompletionHandler<void(RefPtr<WebPageProxy>&&)>&& completionHandler) final
{
auto userInitiatedActivity = page.process().userInitiatedActivity(navigationActionData.userGestureTokenIdentifier);
WebKitNavigationAction navigationAction(API::NavigationAction::create(WTFMove(navigationActionData), frameInfo.ptr(), nullptr, std::nullopt, WTFMove(resourceRequest), { }, false, WTFMove(userInitiatedActivity)));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
