Title: [227672] trunk/Source/WebCore
- Revision
- 227672
- Author
- [email protected]
- Date
- 2018-01-26 02:45:39 -0800 (Fri, 26 Jan 2018)
Log Message
Remove useless RenderBlockFlow overrides.
https://bugs.webkit.org/show_bug.cgi?id=182139
Reviewed by Manuel Rego Casasnovas.
I think these are leftovers from the CSS regions removal, looking at
blame.
No new tests, no behavior change.
* rendering/RenderBlockFlow.cpp:
* rendering/RenderBlockFlow.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (227671 => 227672)
--- trunk/Source/WebCore/ChangeLog 2018-01-26 09:50:58 UTC (rev 227671)
+++ trunk/Source/WebCore/ChangeLog 2018-01-26 10:45:39 UTC (rev 227672)
@@ -1,3 +1,18 @@
+2018-01-26 Emilio Cobos Álvarez <[email protected]>
+
+ Remove useless RenderBlockFlow overrides.
+ https://bugs.webkit.org/show_bug.cgi?id=182139
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ I think these are leftovers from the CSS regions removal, looking at
+ blame.
+
+ No new tests, no behavior change.
+
+ * rendering/RenderBlockFlow.cpp:
+ * rendering/RenderBlockFlow.h:
+
2018-01-25 Joseph Pecoraro <[email protected]>
Web Inspector: Add InspectorShaderProgram to Unified Sources build
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (227671 => 227672)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2018-01-26 09:50:58 UTC (rev 227671)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2018-01-26 10:45:39 UTC (rev 227672)
@@ -127,11 +127,6 @@
// Do not add any code here. Add it to willBeDestroyed() instead.
}
-void RenderBlockFlow::insertedIntoTree()
-{
- RenderBlock::insertedIntoTree();
-}
-
void RenderBlockFlow::willBeDestroyed()
{
if (!renderTreeBeingDestroyed()) {
@@ -3144,11 +3139,6 @@
return true;
}
-void RenderBlockFlow::updateLogicalHeight()
-{
- RenderBlock::updateLogicalHeight();
-}
-
void RenderBlockFlow::setMultiColumnFlow(RenderMultiColumnFlow& fragmentedFlow)
{
ASSERT(!hasRareBlockFlowData() || !rareBlockFlowData()->m_multiColumnFlow);
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.h (227671 => 227672)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.h 2018-01-26 09:50:58 UTC (rev 227671)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.h 2018-01-26 10:45:39 UTC (rev 227672)
@@ -59,7 +59,6 @@
void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) override;
protected:
- void insertedIntoTree() override;
void willBeDestroyed() override;
// This method is called at the start of layout to wipe away all of the floats in our floating objects list. It also
@@ -78,7 +77,6 @@
LayoutUnit collapsedMarginAfter() const final { return maxPositiveMarginAfter() - maxNegativeMarginAfter(); }
void dirtyLinesFromChangedChild(RenderObject& child) final { lineBoxes().dirtyLinesFromChangedChild(*this, child); }
- void updateLogicalHeight() override;
void paintColumnRules(PaintInfo&, const LayoutPoint&) override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
