Title: [228123] trunk/Source/WebKit
- Revision
- 228123
- Author
- [email protected]
- Date
- 2018-02-05 14:00:59 -0800 (Mon, 05 Feb 2018)
Log Message
Unreviewed, rolling out r227964 and r228087.
https://bugs.webkit.org/show_bug.cgi?id=182508
These introduced an API test failure with
URLTest.HostIsIPAddress alongside commit r228086 (Requested by
mlewis13 on #webkit).
Reverted changesets:
"[SOUP] Ensure domain is valid when converting a WebCore
Cookie to Soup"
https://bugs.webkit.org/show_bug.cgi?id=182328
https://trac.webkit.org/changeset/227964
"WebDriver: addCookie command should prepend a dot to domain
if missing"
https://bugs.webkit.org/show_bug.cgi?id=182328
https://trac.webkit.org/changeset/228087
Patch by Commit Queue <[email protected]> on 2018-02-05
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (228122 => 228123)
--- trunk/Source/WebKit/ChangeLog 2018-02-05 21:45:43 UTC (rev 228122)
+++ trunk/Source/WebKit/ChangeLog 2018-02-05 22:00:59 UTC (rev 228123)
@@ -1,3 +1,24 @@
+2018-02-05 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r227964 and r228087.
+ https://bugs.webkit.org/show_bug.cgi?id=182508
+
+ These introduced an API test failure with
+ URLTest.HostIsIPAddress alongside commit r228086 (Requested by
+ mlewis13 on #webkit).
+
+ Reverted changesets:
+
+ "[SOUP] Ensure domain is valid when converting a WebCore
+ Cookie to Soup"
+ https://bugs.webkit.org/show_bug.cgi?id=182328
+ https://trac.webkit.org/changeset/227964
+
+ "WebDriver: addCookie command should prepend a dot to domain
+ if missing"
+ https://bugs.webkit.org/show_bug.cgi?id=182328
+ https://trac.webkit.org/changeset/228087
+
2018-02-05 Wenson Hsieh <[email protected]>
[Extra zoom mode] Implement number pad UI when editing `tel` and `number` inputs
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (228122 => 228123)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-02-05 21:45:43 UTC (rev 228122)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-02-05 22:00:59 UTC (rev 228123)
@@ -1207,12 +1207,7 @@
// Inherit the domain/host from the main frame's URL if it is not explicitly set.
if (domain.isEmpty())
domain = activeURL.host();
- else if (domain[0] != '.') {
- // RFC 2965: If an explicitly specified value does not start with a dot, the user agent supplies a leading dot.
- // Assume that any host that ends with a digit is trying to be an IP address.
- if (!WebCore::URL::hostIsIPAddress(domain))
- domain = makeString('.', domain);
- }
+
cookie.domain = domain;
if (!cookieObject.getString(WTF::ASCIILiteral("path"), cookie.path))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
