Title: [228125] trunk/Source/WebKit
- Revision
- 228125
- Author
- [email protected]
- Date
- 2018-02-05 14:13:51 -0800 (Mon, 05 Feb 2018)
Log Message
Add DoNotProcessIncomingMessagesWhenWaitingForSyncReply to GetPlugins and RootViewToScreen
https://bugs.webkit.org/show_bug.cgi?id=182458
Reviewed by Chris Dumez.
Added DoNotProcessIncomingMessagesWhenWaitingForSyncReply to GetPlugins and RootViewToScreen
which are found to get sent from WebContent process while ScriptDisallowedScope is present
by a work-in-progress patch on webkit.org/b/182449.
* WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::WebPluginInfoProvider::populatePluginCache):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::rootViewToScreen):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (228124 => 228125)
--- trunk/Source/WebKit/ChangeLog 2018-02-05 22:10:15 UTC (rev 228124)
+++ trunk/Source/WebKit/ChangeLog 2018-02-05 22:13:51 UTC (rev 228125)
@@ -1,3 +1,19 @@
+2018-02-05 Ryosuke Niwa <[email protected]>
+
+ Add DoNotProcessIncomingMessagesWhenWaitingForSyncReply to GetPlugins and RootViewToScreen
+ https://bugs.webkit.org/show_bug.cgi?id=182458
+
+ Reviewed by Chris Dumez.
+
+ Added DoNotProcessIncomingMessagesWhenWaitingForSyncReply to GetPlugins and RootViewToScreen
+ which are found to get sent from WebContent process while ScriptDisallowedScope is present
+ by a work-in-progress patch on webkit.org/b/182449.
+
+ * WebProcess/Plugins/WebPluginInfoProvider.cpp:
+ (WebKit::WebPluginInfoProvider::populatePluginCache):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::rootViewToScreen):
+
2018-02-05 Commit Queue <[email protected]>
Unreviewed, rolling out r227964 and r228087.
Modified: trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp (228124 => 228125)
--- trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp 2018-02-05 22:10:15 UTC (rev 228124)
+++ trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp 2018-02-05 22:13:51 UTC (rev 228125)
@@ -145,7 +145,9 @@
if (!m_pluginCacheIsPopulated) {
HangDetectionDisabler hangDetectionDisabler;
- if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::GetPlugins(m_shouldRefreshPlugins), Messages::WebProcessProxy::GetPlugins::Reply(m_cachedPlugins, m_cachedApplicationPlugins), 0))
+ if (!WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::GetPlugins(m_shouldRefreshPlugins),
+ Messages::WebProcessProxy::GetPlugins::Reply(m_cachedPlugins, m_cachedApplicationPlugins), 0,
+ Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply))
return;
m_shouldRefreshPlugins = false;
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (228124 => 228125)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-02-05 22:10:15 UTC (rev 228124)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-02-05 22:13:51 UTC (rev 228125)
@@ -2890,7 +2890,7 @@
IntRect WebPage::rootViewToScreen(const IntRect& rect)
{
IntRect screenRect;
- sendSync(Messages::WebPageProxy::RootViewToScreen(rect), Messages::WebPageProxy::RootViewToScreen::Reply(screenRect));
+ sendSync(Messages::WebPageProxy::RootViewToScreen(rect), Messages::WebPageProxy::RootViewToScreen::Reply(screenRect), Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply);
return screenRect;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
