Title: [230189] tags/Safari-606.1.11.2/Source/WebKit
- Revision
- 230189
- Author
- [email protected]
- Date
- 2018-04-02 14:59:19 -0700 (Mon, 02 Apr 2018)
Log Message
Cherry-pick r230160. rdar://problem/39094484
Fixed the build when BOOL is not bool.
<rdar://problem/39094484>
Reviewed by Jer Noble.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]): Removed the write-only ivar
_hasControlsManager, the assignment to which was causing the compiler error.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: tags/Safari-606.1.11.2/Source/WebKit/ChangeLog (230188 => 230189)
--- tags/Safari-606.1.11.2/Source/WebKit/ChangeLog 2018-04-02 21:14:09 UTC (rev 230188)
+++ tags/Safari-606.1.11.2/Source/WebKit/ChangeLog 2018-04-02 21:59:19 UTC (rev 230189)
@@ -1,3 +1,31 @@
+2018-04-02 Jason Marcell <[email protected]>
+
+ Cherry-pick r230160. rdar://problem/39094484
+
+ Fixed the build when BOOL is not bool.
+ <rdar://problem/39094484>
+
+ Reviewed by Jer Noble.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]): Removed the write-only ivar
+ _hasControlsManager, the assignment to which was causing the compiler error.
+
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-04-02 Dan Bernstein <[email protected]>
+
+ Fixed the build when BOOL is not bool.
+ <rdar://problem/39094484>
+
+ Reviewed by Jer Noble.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (-[WKFullScreenViewController videoControlsManagerDidChange]): Removed the write-only ivar
+ _hasControlsManager, the assignment to which was causing the compiler error.
+
2018-03-31 Jason Marcell <[email protected]>
Cherry-pick r230128. rdar://problem/39057006
Modified: tags/Safari-606.1.11.2/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (230188 => 230189)
--- tags/Safari-606.1.11.2/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-04-02 21:14:09 UTC (rev 230188)
+++ tags/Safari-606.1.11.2/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-04-02 21:59:19 UTC (rev 230189)
@@ -115,7 +115,6 @@
RetainPtr<NSLayoutConstraint> _topConstraint;
WebKit::FullscreenTouchSecheuristic _secheuristic;
WKFullScreenViewControllerPlaybackSessionModelClient _playbackClient;
- BOOL _hasControlsManager;
CGFloat _nonZeroStatusBarHeight;
}
@@ -195,7 +194,6 @@
_playbackClient.setInterface(playbackSessionInterface);
PlaybackSessionModel* playbackSessionModel = playbackSessionInterface ? playbackSessionInterface->playbackSessionModel() : nullptr;
- _hasControlsManager = playbackSessionModel;
self.playing = playbackSessionModel ? playbackSessionModel->isPlaying() : NO;
[_pipButton setHidden:!playbackSessionModel];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes