Title: [230190] trunk/Tools
- Revision
- 230190
- Author
- [email protected]
- Date
- 2018-04-02 16:05:03 -0700 (Mon, 02 Apr 2018)
Log Message
Remove pre-Network Session code path for allowing any HTTPS certificate on Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=184242
Reviewed by Alexey Proskuryakov.
Following r227364 we use the Network Session (NSURLSession) code path by default in
modern WebKit on Mac and iOS. That is, we no longer use {CF, NS}URLConnection in modern
WebKit on these platforms. So, we can remove code that used NSURLRequest SPI to allow
any HTTPS certificate from localhost and 127.0.0.1 when using {CF, NS}URLConnection.
The equivalent functionality is implemented in TestController::canAuthenticateAgainstProtectionSpace().
* WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (230189 => 230190)
--- trunk/Tools/ChangeLog 2018-04-02 21:59:19 UTC (rev 230189)
+++ trunk/Tools/ChangeLog 2018-04-02 23:05:03 UTC (rev 230190)
@@ -1,3 +1,21 @@
+2018-04-02 Daniel Bates <[email protected]>
+
+ Remove pre-Network Session code path for allowing any HTTPS certificate on Mac and iOS
+ https://bugs.webkit.org/show_bug.cgi?id=184242
+
+ Reviewed by Alexey Proskuryakov.
+
+ Following r227364 we use the Network Session (NSURLSession) code path by default in
+ modern WebKit on Mac and iOS. That is, we no longer use {CF, NS}URLConnection in modern
+ WebKit on these platforms. So, we can remove code that used NSURLRequest SPI to allow
+ any HTTPS certificate from localhost and 127.0.0.1 when using {CF, NS}URLConnection.
+ The equivalent functionality is implemented in TestController::canAuthenticateAgainstProtectionSpace().
+
+ * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
+ (WTR::InjectedBundle::platformInitialize):
+ * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
+ (WTR::InjectedBundle::platformInitialize):
+
2018-04-02 Brady Eidson <[email protected]>
Process swapping on navigation needs to handle server redirects.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm (230189 => 230190)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm 2018-04-02 21:59:19 UTC (rev 230189)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm 2018-04-02 23:05:03 UTC (rev 230190)
@@ -27,10 +27,6 @@
#import <Foundation/Foundation.h>
-@interface NSURLRequest (PrivateThingsWeShouldntReallyUse)
-+(void)setAllowsAnyHTTPSCertificate:(BOOL)allow forHost:(NSString *)host;
-@end
-
namespace WTR {
void InjectedBundle::platformInitialize(WKTypeRef)
@@ -46,9 +42,6 @@
[dict setObject:languages forKey:@"AppleLanguages"];
[[NSUserDefaults standardUserDefaults] setVolatileDomain:dict.get() forName:NSArgumentDomain];
-
- [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
- [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];
}
} // namespace WTR
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (230189 => 230190)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm 2018-04-02 21:59:19 UTC (rev 230189)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm 2018-04-02 23:05:03 UTC (rev 230190)
@@ -28,10 +28,6 @@
#import <Foundation/Foundation.h>
-@interface NSURLRequest (PrivateThingsWeShouldntReallyUse)
-+(void)setAllowsAnyHTTPSCertificate:(BOOL)allow forHost:(NSString *)host;
-@end
-
@interface NSSound ()
+ (void)_setAlertType:(NSUInteger)alertType;
@end
@@ -87,9 +83,6 @@
// A distributed notification is delivered to all applications, but it should be harmless, and it's the only way to update all underlying frameworks anyway.
[[NSDistributedNotificationCenter defaultCenter] postNotificationName:@"AppleAquaAntiAliasingChanged" object:nil userInfo:nil deliverImmediately:YES];
- [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
- [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];
-
[NSSound _setAlertType:0];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes