Title: [231573] trunk/Source/WebKit
- Revision
- 231573
- Author
- [email protected]
- Date
- 2018-05-09 10:30:39 -0700 (Wed, 09 May 2018)
Log Message
[iOS] Tell PDFHostViewController when animated resizes begin and end
https://bugs.webkit.org/show_bug.cgi?id=185477
<rdar://problem/39875372>
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
* UIProcess/Cocoa/WKWebViewContentProvider.h:
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_beginAnimatedResize]):
(-[WKPDFView web_endAnimatedResize]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (231572 => 231573)
--- trunk/Source/WebKit/ChangeLog 2018-05-09 17:29:39 UTC (rev 231572)
+++ trunk/Source/WebKit/ChangeLog 2018-05-09 17:30:39 UTC (rev 231573)
@@ -1,3 +1,19 @@
+2018-05-09 Andy Estes <[email protected]>
+
+ [iOS] Tell PDFHostViewController when animated resizes begin and end
+ https://bugs.webkit.org/show_bug.cgi?id=185477
+ <rdar://problem/39875372>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _beginAnimatedResizeWithUpdates:]):
+ (-[WKWebView _endAnimatedResize]):
+ * UIProcess/Cocoa/WKWebViewContentProvider.h:
+ * UIProcess/ios/WKPDFView.mm:
+ (-[WKPDFView web_beginAnimatedResize]):
+ (-[WKPDFView web_endAnimatedResize]):
+
2018-05-09 Michael Catanzaro <[email protected]>
Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (231572 => 231573)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-05-09 17:29:39 UTC (rev 231572)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-05-09 17:30:39 UTC (rev 231573)
@@ -5147,6 +5147,8 @@
if (![self usesStandardContentView] || !_hasCommittedLoadForMainFrame || CGRectIsEmpty(oldBounds) || oldUnobscuredContentRect.isEmpty()) {
updateBlock();
+ if ([_customContentView respondsToSelector:@selector(web_beginAnimatedResize)])
+ [_customContentView web_beginAnimatedResize];
return;
}
@@ -5262,6 +5264,9 @@
{
LOG_WITH_STREAM(VisibleRects, stream << "-[WKWebView " << _page->pageID() << " _endAnimatedResize:] " << " _dynamicViewportUpdateMode " << (int)_dynamicViewportUpdateMode);
+ if ([_customContentView respondsToSelector:@selector(web_endAnimatedResize)])
+ [_customContentView web_endAnimatedResize];
+
if (_dynamicViewportUpdateMode == DynamicViewportUpdateMode::NotResizing)
return;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h (231572 => 231573)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h 2018-05-09 17:29:39 UTC (rev 231572)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h 2018-05-09 17:30:39 UTC (rev 231573)
@@ -59,6 +59,8 @@
- (void)web_scrollViewWillBeginZooming:(UIScrollView *)scrollView withView:(UIView *)view;
- (void)web_scrollViewDidEndZooming:(UIScrollView *)scrollView withView:(UIView *)view atScale:(CGFloat)scale;
- (void)web_scrollViewDidZoom:(UIScrollView *)scrollView;
+- (void)web_beginAnimatedResize;
+- (void)web_endAnimatedResize;
@property (nonatomic, readonly) NSData *web_dataRepresentation;
@property (nonatomic, readonly) NSString *web_suggestedFilename;
@property (nonatomic, readonly) BOOL web_isBackground;
Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm (231572 => 231573)
--- trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm 2018-05-09 17:29:39 UTC (rev 231572)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm 2018-05-09 17:30:39 UTC (rev 231573)
@@ -344,6 +344,16 @@
[_hostViewController updatePDFViewLayout];
}
+- (void)web_beginAnimatedResize
+{
+ [_hostViewController beginPDFViewRotation];
+}
+
+- (void)web_endAnimatedResize
+{
+ [_hostViewController endPDFViewRotation];
+}
+
- (NSData *)web_dataRepresentation
{
return _data.get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
