Title: [231574] trunk/LayoutTests
Revision
231574
Author
[email protected]
Date
2018-05-09 11:02:32 -0700 (Wed, 09 May 2018)

Log Message

Unflake some additional AppCache tests
https://bugs.webkit.org/show_bug.cgi?id=185467

Reviewed by Alex Christensen.

Remove JS console logging for two tests that are testing crash scenarios.
Increase the time it takes to load appcache entries so that aborting
is done prior entry loading completion for two other tests.

* TestExpectations:
* http/tests/appcache/deferred-events-delete-while-raising-expected.txt:
* http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt:
* http/tests/appcache/resources/abort-cache-onprogress.manifest:
* http/tests/appcache/resources/not-exist.vob.php:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (231573 => 231574)


--- trunk/LayoutTests/ChangeLog	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/ChangeLog	2018-05-09 18:02:32 UTC (rev 231574)
@@ -1,3 +1,20 @@
+2018-05-09  Youenn Fablet  <[email protected]>
+
+        Unflake some additional AppCache tests
+        https://bugs.webkit.org/show_bug.cgi?id=185467
+
+        Reviewed by Alex Christensen.
+
+        Remove JS console logging for two tests that are testing crash scenarios.
+        Increase the time it takes to load appcache entries so that aborting
+        is done prior entry loading completion for two other tests.
+
+        * TestExpectations:
+        * http/tests/appcache/deferred-events-delete-while-raising-expected.txt:
+        * http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt:
+        * http/tests/appcache/resources/abort-cache-onprogress.manifest:
+        * http/tests/appcache/resources/not-exist.vob.php:
+
 2018-05-09  Per Arne Vollan  <[email protected]>
 
         [Win] The test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is timing out.

Modified: trunk/LayoutTests/TestExpectations (231573 => 231574)


--- trunk/LayoutTests/TestExpectations	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/TestExpectations	2018-05-09 18:02:32 UTC (rev 231574)
@@ -1009,13 +1009,8 @@
 webkit.org/b/134550 http/tests/cache/iframe-304-crash.html [ Failure Pass ]
 webkit.org/b/141267 http/tests/misc/detached-frame-console.html [ Pass Failure ]
 
-# Aborting application cache abort tests are intrinsically flaky.
-webkit.org/b/87633 http/tests/appcache/abort-cache-onchecking-manifest-404.html [ Pass Failure ]
-webkit.org/b/87633 http/tests/appcache/abort-cache-ondownloading-resource-404.html [ Pass Failure ]
-webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising-timer.html [ Pass Failure ]
-webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising.html [ Pass Failure ]
-webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ]
-
+http/tests/appcache/deferred-events-delete-while-raising-timer.html [ DumpJSConsoleLogInStdErr ]
+http/tests/appcache/deferred-events-delete-while-raising.html [ DumpJSConsoleLogInStdErr ]
 http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr ]
 http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr ]
 http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]
@@ -1022,8 +1017,6 @@
 
 webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ]
 
-webkit.org/b/183684 http/tests/appcache/abort-cache-onprogress.html [ Pass Failure ]
-
 # The current expectations for this test only make sense for WebKit on iOS; other platforms can have very different behaviors.
 webkit.org/b/141488 fast/replaced/pdf-as-object-and-embed.html [ Skip ]
 

Modified: trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt (231573 => 231574)


--- trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt	2018-05-09 18:02:32 UTC (rev 231574)
@@ -1,7 +1,3 @@
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
 Test the destruction of an iframe while deferred events are being raised does not crash the system.
 
 SUCCESS

Modified: trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt (231573 => 231574)


--- trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt	2018-05-09 18:02:32 UTC (rev 231574)
@@ -1,7 +1,3 @@
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
 Test the destruction of an iframe while deferred events are being raised does not crash the system.
 
 SUCCESS

Modified: trunk/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest (231573 => 231574)


--- trunk/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/http/tests/appcache/resources/abort-cache-onprogress.manifest	2018-05-09 18:02:32 UTC (rev 231574)
@@ -2,5 +2,4 @@
 abort-cache-onprogress-1.text
 abort-cache-onprogress-2.text
 abort-cache-onprogress-3.text
-abort-cache-onprogress-4.text
-
+slow-resource.php

Modified: trunk/LayoutTests/http/tests/appcache/resources/not-exist.vob.php (231573 => 231574)


--- trunk/LayoutTests/http/tests/appcache/resources/not-exist.vob.php	2018-05-09 17:30:39 UTC (rev 231573)
+++ trunk/LayoutTests/http/tests/appcache/resources/not-exist.vob.php	2018-05-09 18:02:32 UTC (rev 231574)
@@ -1,5 +1,5 @@
 <?php
-sleep(1000);
+sleep(5000);
 header('http/1.1 404 Not Found');
 print("File not found\n");
 ?>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to