Title: [232298] trunk/Source/WebKit
Revision
232298
Author
[email protected]
Date
2018-05-30 10:42:51 -0700 (Wed, 30 May 2018)

Log Message

Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
https://bugs.webkit.org/show_bug.cgi?id=186097
<rdar://problem/40651225>

Reviewed by Tim Horton.

Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate(). Otherwise,
apps may get stuck on _doAfterNextPresentationUpdate because the WebProcess got suspended.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (232297 => 232298)


--- trunk/Source/WebKit/ChangeLog	2018-05-30 17:06:09 UTC (rev 232297)
+++ trunk/Source/WebKit/ChangeLog	2018-05-30 17:42:51 UTC (rev 232298)
@@ -1,3 +1,17 @@
+2018-05-30  Chris Dumez  <[email protected]>
+
+        Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
+        https://bugs.webkit.org/show_bug.cgi?id=186097
+        <rdar://problem/40651225>
+
+        Reviewed by Tim Horton.
+
+        Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate(). Otherwise,
+        apps may get stuck on _doAfterNextPresentationUpdate because the WebProcess got suspended.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::callAfterNextPresentationUpdate):
+
 2018-05-29  Tim Horton  <[email protected]>
 
         Fix the build

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (232297 => 232298)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-05-30 17:06:09 UTC (rev 232297)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-05-30 17:42:51 UTC (rev 232298)
@@ -7351,7 +7351,9 @@
         return;
     }
 
-    m_drawingArea->dispatchAfterEnsuringDrawing(WTFMove(callback));
+    m_drawingArea->dispatchAfterEnsuringDrawing([callback = WTFMove(callback), backgroundActivity = m_process->throttler().backgroundActivityToken()](CallbackBase::Error error) {
+        callback(error);
+    });
 }
 
 void WebPageProxy::setShouldScaleViewToFitDocument(bool shouldScaleViewToFitDocument)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to