Title: [232299] trunk/Source/WebKit
- Revision
- 232299
- Author
- [email protected]
- Date
- 2018-05-30 10:46:49 -0700 (Wed, 30 May 2018)
Log Message
Fix a few issues in WKFullScreenViewController
https://bugs.webkit.org/show_bug.cgi?id=186067
<rdar://problem/40630944>
Reviewed by Darin Adler.
The check in setInterface() is checking the wrong pointer:
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
The check in -_effectiveFullscreenInsetTop is backwards:
(-[WKFullScreenViewController _effectiveFullscreenInsetTop]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232298 => 232299)
--- trunk/Source/WebKit/ChangeLog 2018-05-30 17:42:51 UTC (rev 232298)
+++ trunk/Source/WebKit/ChangeLog 2018-05-30 17:46:49 UTC (rev 232299)
@@ -1,3 +1,18 @@
+2018-05-30 Jer Noble <[email protected]>
+
+ Fix a few issues in WKFullScreenViewController
+ https://bugs.webkit.org/show_bug.cgi?id=186067
+ <rdar://problem/40630944>
+
+ Reviewed by Darin Adler.
+
+ The check in setInterface() is checking the wrong pointer:
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
+
+ The check in -_effectiveFullscreenInsetTop is backwards:
+ (-[WKFullScreenViewController _effectiveFullscreenInsetTop]):
+
2018-05-30 Chris Dumez <[email protected]>
Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (232298 => 232299)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-05-30 17:42:51 UTC (rev 232298)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-05-30 17:46:49 UTC (rev 232299)
@@ -67,7 +67,7 @@
return;
if (m_interface && m_interface->playbackSessionModel())
- interface->playbackSessionModel()->removeClient(*this);
+ m_interface->playbackSessionModel()->removeClient(*this);
m_interface = interface;
if (m_interface && m_interface->playbackSessionModel())
interface->playbackSessionModel()->addClient(*this);
@@ -360,7 +360,7 @@
@dynamic _effectiveFullscreenInsetTop;
- (CGFloat)_effectiveFullscreenInsetTop
{
- if (!self.prefersStatusBarHidden)
+ if (self.prefersStatusBarHidden)
return 0;
CGRect cancelFrame = _cancelButton.get().frame;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
