Title: [232303] trunk/Source/WebKit
Revision
232303
Author
[email protected]
Date
2018-05-30 12:23:57 -0700 (Wed, 30 May 2018)

Log Message

Unreviewed, a quick build fix for r232276.

Enabled SecItemShim again as it turns out to be useful for CFNetwork APIs that
query Keychains underneath us.

* NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (232302 => 232303)


--- trunk/Source/WebKit/ChangeLog	2018-05-30 19:21:34 UTC (rev 232302)
+++ trunk/Source/WebKit/ChangeLog	2018-05-30 19:23:57 UTC (rev 232303)
@@ -1,3 +1,15 @@
+2018-05-30  Jiewen Tan  <[email protected]>
+
+        Unreviewed, a quick build fix for r232276.
+
+        Enabled SecItemShim again as it turns out to be useful for CFNetwork APIs that
+        query Keychains underneath us.
+
+        * NetworkProcess/ios/NetworkProcessIOS.mm:
+        (WebKit::NetworkProcess::platformInitializeNetworkProcess):
+        * NetworkProcess/mac/NetworkProcessMac.mm:
+        (WebKit::NetworkProcess::platformInitializeNetworkProcess):
+
 2018-05-30  Jer Noble  <[email protected]>
 
         Auto-pip should use main content heuristic.

Modified: trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm (232302 => 232303)


--- trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm	2018-05-30 19:21:34 UTC (rev 232302)
+++ trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm	2018-05-30 19:23:57 UTC (rev 232303)
@@ -84,7 +84,8 @@
 
 void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters& parameters)
 {
-#if ENABLE(SEC_ITEM_SHIM) && !HAVE(SEC_KEY_PROXY)
+#if ENABLE(SEC_ITEM_SHIM)
+    // SecItemShim is needed for CFNetwork APIs that query Keychains beneath us.
     initializeSecItemShim(*this);
 #endif
     platformInitializeNetworkProcessCocoa(parameters);

Modified: trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm (232302 => 232303)


--- trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm	2018-05-30 19:21:34 UTC (rev 232302)
+++ trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm	2018-05-30 19:23:57 UTC (rev 232303)
@@ -104,7 +104,8 @@
 {
     platformInitializeNetworkProcessCocoa(parameters);
 
-#if ENABLE(SEC_ITEM_SHIM) && !HAVE(SEC_KEY_PROXY)
+#if ENABLE(SEC_ITEM_SHIM)
+    // SecItemShim is needed for CFNetwork APIs that query Keychains beneath us.
     initializeSecItemShim(*this);
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to