[webkit-changes] [232304] trunk/Source/ThirdParty/ANGLE

Wed, 30 May 2018 13:02:57 -0700

Title: [232304] trunk/Source/ThirdParty/ANGLE
Revision
232304
Author
[email protected]
Date
2018-05-30 12:47:58 -0700 (Wed, 30 May 2018)

Log Message

ANGLE: Fix clang static analyzer issues in GetExecutablePath() and GetExecutableDirectory()
<https://webkit.org/b/186106>
<rdar://problem/40659179>

Reviewed by Alex Christensen.

* src/common/system_utils_linux.cpp:
(angle::GetExecutablePath):
(angle::GetExecutableDirectory):
* src/common/system_utils_mac.cpp:
(angle::GetExecutablePath):
(angle::GetExecutableDirectory):
* src/common/system_utils_win.cpp:
(angle::GetExecutablePath):
(angle::GetExecutableDirectory):

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (232303 => 232304)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2018-05-30 19:23:57 UTC (rev 232303)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2018-05-30 19:47:58 UTC (rev 232304)
@@ -1,3 +1,21 @@
+2018-05-30  David Kilzer  <[email protected]>
+
+        ANGLE: Fix clang static analyzer issues in GetExecutablePath() and GetExecutableDirectory()
+        <https://webkit.org/b/186106>
+        <rdar://problem/40659179>
+
+        Reviewed by Alex Christensen.
+
+        * src/common/system_utils_linux.cpp:
+        (angle::GetExecutablePath):
+        (angle::GetExecutableDirectory):
+        * src/common/system_utils_mac.cpp:
+        (angle::GetExecutablePath):
+        (angle::GetExecutableDirectory):
+        * src/common/system_utils_win.cpp:
+        (angle::GetExecutablePath):
+        (angle::GetExecutableDirectory):
+
 2018-05-22  Ryan Haddad  <[email protected]>
 
         Unreviewed, rolling out r232052.

Modified: trunk/Source/ThirdParty/ANGLE/src/common/system_utils_linux.cpp (232303 => 232304)


--- trunk/Source/ThirdParty/ANGLE/src/common/system_utils_linux.cpp	2018-05-30 19:23:57 UTC (rev 232303)
+++ trunk/Source/ThirdParty/ANGLE/src/common/system_utils_linux.cpp	2018-05-30 19:47:58 UTC (rev 232304)
@@ -49,7 +49,7 @@
 const char *GetExecutablePath()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exePath = GetExecutablePathImpl();
+    const static std::string exePath = GetExecutablePathImpl();
     return exePath.c_str();
 }
 
@@ -56,7 +56,7 @@
 const char *GetExecutableDirectory()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exeDir = GetExecutableDirectoryImpl();
+    const static std::string exeDir = GetExecutableDirectoryImpl();
     return exeDir.c_str();
 }

Modified: trunk/Source/ThirdParty/ANGLE/src/common/system_utils_mac.cpp (232303 => 232304)


--- trunk/Source/ThirdParty/ANGLE/src/common/system_utils_mac.cpp	2018-05-30 19:23:57 UTC (rev 232303)
+++ trunk/Source/ThirdParty/ANGLE/src/common/system_utils_mac.cpp	2018-05-30 19:47:58 UTC (rev 232304)
@@ -54,7 +54,7 @@
 const char *GetExecutablePath()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exePath = GetExecutablePathImpl();
+    const static std::string exePath = GetExecutablePathImpl();
     return exePath.c_str();
 }
 
@@ -61,7 +61,7 @@
 const char *GetExecutableDirectory()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exeDir = GetExecutableDirectoryImpl();
+    const static std::string exeDir = GetExecutableDirectoryImpl();
     return exeDir.c_str();
 }

Modified: trunk/Source/ThirdParty/ANGLE/src/common/system_utils_win.cpp (232303 => 232304)


--- trunk/Source/ThirdParty/ANGLE/src/common/system_utils_win.cpp	2018-05-30 19:23:57 UTC (rev 232303)
+++ trunk/Source/ThirdParty/ANGLE/src/common/system_utils_win.cpp	2018-05-30 19:47:58 UTC (rev 232304)
@@ -39,7 +39,7 @@
 const char *GetExecutablePath()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exePath = GetExecutablePathImpl();
+    const static std::string exePath = GetExecutablePathImpl();
     return exePath.c_str();
 }
 
@@ -46,7 +46,7 @@
 const char *GetExecutableDirectory()
 {
     // TODO(jmadill): Make global static string thread-safe.
-    const static std::string &exeDir = GetExecutableDirectoryImpl();
+    const static std::string exeDir = GetExecutableDirectoryImpl();
     return exeDir.c_str();
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to