Title: [232601] trunk/Source/WebKit
- Revision
- 232601
- Author
- [email protected]
- Date
- 2018-06-07 15:03:15 -0700 (Thu, 07 Jun 2018)
Log Message
REGRESSION (r232544): Pages are blank after homing out and then resuming on iPad
https://bugs.webkit.org/show_bug.cgi?id=186408
<rdar://problem/40907111>
Reviewed by Wenson Hsieh.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):
Clients who use _resizeWhileHidingContentWithUpdates don't call
_endAnimatedResize; the former API is a one-shot. We can't wait for
_endAnimatedResize to complete the animation (and don't need to, since
the content is hidden), but instead should just finish it when the
commit with the resized tiles arrives.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232600 => 232601)
--- trunk/Source/WebKit/ChangeLog 2018-06-07 21:16:16 UTC (rev 232600)
+++ trunk/Source/WebKit/ChangeLog 2018-06-07 22:03:15 UTC (rev 232601)
@@ -1,3 +1,19 @@
+2018-06-07 Tim Horton <[email protected]>
+
+ REGRESSION (r232544): Pages are blank after homing out and then resuming on iPad
+ https://bugs.webkit.org/show_bug.cgi?id=186408
+ <rdar://problem/40907111>
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _resizeWhileHidingContentWithUpdates:]):
+ Clients who use _resizeWhileHidingContentWithUpdates don't call
+ _endAnimatedResize; the former API is a one-shot. We can't wait for
+ _endAnimatedResize to complete the animation (and don't need to, since
+ the content is hidden), but instead should just finish it when the
+ commit with the resized tiles arrives.
+
2018-06-07 Jiewen Tan <[email protected]>
Use the same overloaded addInputString in WKContentViewInteraction
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (232600 => 232601)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-07 21:16:16 UTC (rev 232600)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-07 22:03:15 UTC (rev 232601)
@@ -5375,6 +5375,10 @@
if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::ResizingWithAnimation) {
[_contentView setHidden:YES];
_dynamicViewportUpdateMode = WebKit::DynamicViewportUpdateMode::ResizingWithDocumentHidden;
+
+ // _resizeWhileHidingContentWithUpdates is used by itself; the client will
+ // not call endAnimatedResize, so we can't wait for it.
+ _waitingForEndAnimatedResize = NO;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
