Title: [232602] trunk/Source/_javascript_Core
Revision
232602
Author
[email protected]
Date
2018-06-07 15:06:43 -0700 (Thu, 07 Jun 2018)

Log Message

TierUpCheckInjectionPhase systematically never puts the outer-most loop in an inner loop's vector of outer loops
https://bugs.webkit.org/show_bug.cgi?id=186386

Reviewed by Filip Pizlo.

This looks like an 8% speedup on Kraken's imaging-gaussian-blur subtest.

* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (232601 => 232602)


--- trunk/Source/_javascript_Core/ChangeLog	2018-06-07 22:03:15 UTC (rev 232601)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-06-07 22:06:43 UTC (rev 232602)
@@ -1,3 +1,15 @@
+2018-06-07  Saam Barati  <[email protected]>
+
+        TierUpCheckInjectionPhase systematically never puts the outer-most loop in an inner loop's vector of outer loops
+        https://bugs.webkit.org/show_bug.cgi?id=186386
+
+        Reviewed by Filip Pizlo.
+
+        This looks like an 8% speedup on Kraken's imaging-gaussian-blur subtest.
+
+        * dfg/DFGTierUpCheckInjectionPhase.cpp:
+        (JSC::DFG::TierUpCheckInjectionPhase::run):
+
 2018-06-02  Filip Pizlo  <[email protected]>
 
         FunctionRareData::m_objectAllocationProfileWatchpoint is racy

Modified: trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp (232601 => 232602)


--- trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp	2018-06-07 22:03:15 UTC (rev 232601)
+++ trunk/Source/_javascript_Core/dfg/DFGTierUpCheckInjectionPhase.cpp	2018-06-07 22:06:43 UTC (rev 232602)
@@ -122,8 +122,7 @@
                         if (it != naturalLoopToLoopHint.end())
                             descriptor.osrEntryCandidates.append(it->value);
                     }
-                    if (!descriptor.osrEntryCandidates.isEmpty())
-                        tierUpHierarchy.add(bytecodeIndex, WTFMove(descriptor));
+                    tierUpHierarchy.add(bytecodeIndex, WTFMove(descriptor));
                 }
                 break;
             }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to