Title: [233388] trunk/Tools
- Revision
- 233388
- Author
- [email protected]
- Date
- 2018-06-29 19:12:45 -0700 (Fri, 29 Jun 2018)
Log Message
build-webkit: Perl "use of uninitialized value $previousContents"
https://bugs.webkit.org/show_bug.cgi?id=185776
Reviewed by Michael Catanzaro.
Fixes an issue where reading an empty cached argument file would cause
Perl "uninitialized value" warnings of the form:
Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
* Scripts/webkitdirs.pm:
(isCachedArgumentfileOutOfDate):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233387 => 233388)
--- trunk/Tools/ChangeLog 2018-06-30 02:11:01 UTC (rev 233387)
+++ trunk/Tools/ChangeLog 2018-06-30 02:12:45 UTC (rev 233388)
@@ -1,5 +1,20 @@
2018-06-29 Daniel Bates <[email protected]>
+ build-webkit: Perl "use of uninitialized value $previousContents"
+ https://bugs.webkit.org/show_bug.cgi?id=185776
+
+ Reviewed by Michael Catanzaro.
+
+ Fixes an issue where reading an empty cached argument file would cause
+ Perl "uninitialized value" warnings of the form:
+ Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
+ Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
+
+ * Scripts/webkitdirs.pm:
+ (isCachedArgumentfileOutOfDate):
+
+2018-06-29 Daniel Bates <[email protected]>
+
Perl uninitialized value $isEnabled when running build-jsc using a CMake build
https://bugs.webkit.org/show_bug.cgi?id=187208
Modified: trunk/Tools/Scripts/webkitdirs.pm (233387 => 233388)
--- trunk/Tools/Scripts/webkitdirs.pm 2018-06-30 02:11:01 UTC (rev 233387)
+++ trunk/Tools/Scripts/webkitdirs.pm 2018-06-30 02:12:45 UTC (rev 233388)
@@ -2028,7 +2028,7 @@
}
open(CONTENTS_FILE, $filename);
- chomp(my $previousContents = <CONTENTS_FILE>);
+ chomp(my $previousContents = <CONTENTS_FILE> || "");
close(CONTENTS_FILE);
if ($previousContents ne $currentContents) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
