Title: [233389] trunk
- Revision
- 233389
- Author
- [email protected]
- Date
- 2018-06-29 20:02:24 -0700 (Fri, 29 Jun 2018)
Log Message
REGRESSION (r232806): Facebook login fields have blue fill background instead of white
https://bugs.webkit.org/show_bug.cgi?id=187207
Source/WebCore:
<rdar://problem/41606349>
Reviewed by Tim Horton.
This happens because a 'prefers-dark-interface' media query on UA sheet always evaluates to true in dark mode.
Tests: fast/forms/input-background-ua-media-query.html
* css/MediaQueryEvaluator.cpp:
(WebCore::prefersDarkInterfaceEvaluate):
Make prefers-dark-interface media query match only when using system appearance.
LayoutTests:
Reviewed by Tim Horton.
* fast/forms/input-background-ua-media-query-expected.html: Added.
* fast/forms/input-background-ua-media-query.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233388 => 233389)
--- trunk/LayoutTests/ChangeLog 2018-06-30 02:12:45 UTC (rev 233388)
+++ trunk/LayoutTests/ChangeLog 2018-06-30 03:02:24 UTC (rev 233389)
@@ -1,3 +1,13 @@
+2018-06-29 Antti Koivisto <[email protected]>
+
+ REGRESSION (r232806): Facebook login fields have blue fill background instead of white
+ https://bugs.webkit.org/show_bug.cgi?id=187207
+
+ Reviewed by Tim Horton.
+
+ * fast/forms/input-background-ua-media-query-expected.html: Added.
+ * fast/forms/input-background-ua-media-query.html: Added.
+
2018-06-29 Daniel Bates <[email protected]>
REGRESSION (r230921): Cannot log in to forums.swift.org using GitHub account
Added: trunk/LayoutTests/fast/forms/input-background-ua-media-query-expected.html (0 => 233389)
--- trunk/LayoutTests/fast/forms/input-background-ua-media-query-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/input-background-ua-media-query-expected.html 2018-06-30 03:02:24 UTC (rev 233389)
@@ -0,0 +1,4 @@
+<style>
+body { background-color: green }
+</style>
+<input value=foo style="background-color:white">
Added: trunk/LayoutTests/fast/forms/input-background-ua-media-query.html (0 => 233389)
--- trunk/LayoutTests/fast/forms/input-background-ua-media-query.html (rev 0)
+++ trunk/LayoutTests/fast/forms/input-background-ua-media-query.html 2018-06-30 03:02:24 UTC (rev 233389)
@@ -0,0 +1,5 @@
+<style>
+body { background-color: green }
+</style>
+<input value=foo>
+
Modified: trunk/Source/WebCore/ChangeLog (233388 => 233389)
--- trunk/Source/WebCore/ChangeLog 2018-06-30 02:12:45 UTC (rev 233388)
+++ trunk/Source/WebCore/ChangeLog 2018-06-30 03:02:24 UTC (rev 233389)
@@ -1,3 +1,20 @@
+2018-06-29 Antti Koivisto <[email protected]>
+
+ REGRESSION (r232806): Facebook login fields have blue fill background instead of white
+ https://bugs.webkit.org/show_bug.cgi?id=187207
+ <rdar://problem/41606349>
+
+ Reviewed by Tim Horton.
+
+ This happens because a 'prefers-dark-interface' media query on UA sheet always evaluates to true in dark mode.
+
+ Tests: fast/forms/input-background-ua-media-query.html
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::prefersDarkInterfaceEvaluate):
+
+ Make prefers-dark-interface media query match only when using system appearance.
+
2018-06-29 Daniel Bates <[email protected]>
REGRESSION (r230921): Cannot log in to forums.swift.org using GitHub account
Modified: trunk/Source/WebCore/css/MediaQueryEvaluator.cpp (233388 => 233389)
--- trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2018-06-30 02:12:45 UTC (rev 233388)
+++ trunk/Source/WebCore/css/MediaQueryEvaluator.cpp 2018-06-30 03:02:24 UTC (rev 233389)
@@ -717,7 +717,7 @@
{
bool prefersDarkInterface = false;
- if (!frame.page()->defaultAppearance())
+ if (frame.page()->useSystemAppearance() && !frame.page()->defaultAppearance())
prefersDarkInterface = true;
if (!value)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
