Title: [233508] trunk/Source/WebCore
- Revision
- 233508
- Author
- [email protected]
- Date
- 2018-07-04 13:08:19 -0700 (Wed, 04 Jul 2018)
Log Message
[GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=187304
Patch by Thibault Saunier <[email protected]> on 2018-07-04
Reviewed by Philippe Normand.
We let parsebin build the StreamCollection for us and pass extra metadata through the
`TAG_EVENT` pushing the collection ourself is not bringing anything but adds extra work in the
MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.
MediaStream layout tests already test that code path.
* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebCore::webkitMediaStreamSrcPadProbeCb):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233507 => 233508)
--- trunk/Source/WebCore/ChangeLog 2018-07-04 18:45:20 UTC (rev 233507)
+++ trunk/Source/WebCore/ChangeLog 2018-07-04 20:08:19 UTC (rev 233508)
@@ -1,3 +1,19 @@
+2018-07-04 Thibault Saunier <[email protected]>
+
+ [GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
+ https://bugs.webkit.org/show_bug.cgi?id=187304
+
+ Reviewed by Philippe Normand.
+
+ We let parsebin build the StreamCollection for us and pass extra metadata through the
+ `TAG_EVENT` pushing the collection ourself is not bringing anything but adds extra work in the
+ MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.
+
+ MediaStream layout tests already test that code path.
+
+ * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
+ (WebCore::webkitMediaStreamSrcPadProbeCb):
+
2018-07-04 Frederic Wang <[email protected]>
[WebIDL] Remove custom bindings for HTMLDocument
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp (233507 => 233508)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2018-07-04 18:45:20 UTC (rev 233507)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2018-07-04 20:08:19 UTC (rev 233508)
@@ -383,7 +383,6 @@
gst_event_unref(event);
gst_pad_push_event(pad, stream_start);
- gst_pad_push_event(pad, gst_event_new_stream_collection(self->streamCollection.get()));
gst_pad_push_event(pad, gst_event_new_tag(mediaStreamTrackPrivateGetTags(data->track.get())));
webkitMediaStreamSrcAddPad(self, pad, data->pad_template);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
