Title: [233509] trunk/Source/WebCore
- Revision
- 233509
- Author
- [email protected]
- Date
- 2018-07-04 13:12:37 -0700 (Wed, 04 Jul 2018)
Log Message
RealtimeIncomingVideoSources: Call stop() directly in the destructor
https://bugs.webkit.org/show_bug.cgi?id=187303
Patch by Thibault Saunier <[email protected]> on 2018-07-04
Reviewed by Youenn Fablet.
Avoiding to call stopProducingData when we are not actually producing data.
This fixes tests that will run once the WPE/GTK PeerConnection implementation is merged.
* platform/mediastream/RealtimeIncomingVideoSource.h:
(WebCore::RealtimeIncomingVideoSource::~RealtimeIncomingVideoSource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233508 => 233509)
--- trunk/Source/WebCore/ChangeLog 2018-07-04 20:08:19 UTC (rev 233508)
+++ trunk/Source/WebCore/ChangeLog 2018-07-04 20:12:37 UTC (rev 233509)
@@ -1,5 +1,19 @@
2018-07-04 Thibault Saunier <[email protected]>
+ RealtimeIncomingVideoSources: Call stop() directly in the destructor
+ https://bugs.webkit.org/show_bug.cgi?id=187303
+
+ Reviewed by Youenn Fablet.
+
+ Avoiding to call stopProducingData when we are not actually producing data.
+
+ This fixes tests that will run once the WPE/GTK PeerConnection implementation is merged.
+
+ * platform/mediastream/RealtimeIncomingVideoSource.h:
+ (WebCore::RealtimeIncomingVideoSource::~RealtimeIncomingVideoSource):
+
+2018-07-04 Thibault Saunier <[email protected]>
+
[GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=187304
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h (233508 => 233509)
--- trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h 2018-07-04 20:08:19 UTC (rev 233508)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h 2018-07-04 20:12:37 UTC (rev 233509)
@@ -44,7 +44,10 @@
class RealtimeIncomingVideoSource : public RealtimeMediaSource, private rtc::VideoSinkInterface<webrtc::VideoFrame> {
public:
static Ref<RealtimeIncomingVideoSource> create(rtc::scoped_refptr<webrtc::VideoTrackInterface>&&, String&&);
- ~RealtimeIncomingVideoSource() { stopProducingData(); }
+ ~RealtimeIncomingVideoSource()
+ {
+ stop();
+ }
void setSourceTrack(rtc::scoped_refptr<webrtc::VideoTrackInterface>&&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
