Title: [233686] trunk/Source/WebInspectorUI
- Revision
- 233686
- Author
- [email protected]
- Date
- 2018-07-10 09:44:45 -0700 (Tue, 10 Jul 2018)
Log Message
Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
https://bugs.webkit.org/show_bug.cgi?id=187482
<rdar://problem/41989190>
Reviewed by Brian Burg.
Subclasses of NavigationSidebarPanel must process tree selection changes
even when collapsed. Sidebar panels perform critical controller tasks
for their tabs, such as updating the view when pausing in the debugger,
and when the hierarchical path component selection changes.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/SourcesSidebarPanel.js:
(WI.SourcesSidebarPanel.prototype._treeSelectionDidChange):
* UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel._treeSelectionDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (233685 => 233686)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
@@ -1,3 +1,27 @@
+2018-07-10 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=187482
+ <rdar://problem/41989190>
+
+ Reviewed by Brian Burg.
+
+ Subclasses of NavigationSidebarPanel must process tree selection changes
+ even when collapsed. Sidebar panels perform critical controller tasks
+ for their tabs, such as updating the view when pausing in the debugger,
+ and when the hierarchical path component selection changes.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
+ * UserInterface/Views/ResourceSidebarPanel.js:
+ (WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
+ * UserInterface/Views/SearchSidebarPanel.js:
+ (WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
+ * UserInterface/Views/SourcesSidebarPanel.js:
+ (WI.SourcesSidebarPanel.prototype._treeSelectionDidChange):
+ * UserInterface/Views/StorageSidebarPanel.js:
+ (WI.StorageSidebarPanel._treeSelectionDidChange):
+
2018-07-09 Brian Burg <[email protected]>
REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (233685 => 233686)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2018-07-10 16:44:45 UTC (rev 233686)
@@ -828,7 +828,7 @@
_treeSelectionDidChange(event)
{
- if (!this.visible)
+ if (!this.selected)
return;
let treeElement = event.data.selectedElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (233685 => 233686)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2018-07-10 16:44:45 UTC (rev 233686)
@@ -452,7 +452,7 @@
_treeSelectionDidChange(event)
{
- if (!this.visible)
+ if (!this.selected)
return;
let treeElement = event.data.selectedElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (233685 => 233686)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2018-07-10 16:44:45 UTC (rev 233686)
@@ -363,7 +363,7 @@
_treeSelectionDidChange(event)
{
- if (!this.visible)
+ if (!this.selected)
return;
let treeElement = event.data.selectedElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js (233685 => 233686)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesSidebarPanel.js 2018-07-10 16:44:45 UTC (rev 233686)
@@ -452,7 +452,7 @@
_treeSelectionDidChange(event)
{
- if (!this.visible)
+ if (!this.selected)
return;
let treeElement = event.data.selectedElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js (233685 => 233686)
--- trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js 2018-07-10 16:35:35 UTC (rev 233685)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js 2018-07-10 16:44:45 UTC (rev 233686)
@@ -166,7 +166,7 @@
_treeSelectionDidChange(event)
{
- if (!this.visible)
+ if (!this.selected)
return;
let treeElement = event.data.selectedElement;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
