Diff
Modified: trunk/Source/WebCore/ChangeLog (233686 => 233687)
--- trunk/Source/WebCore/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebCore/ChangeLog 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1,3 +1,14 @@
+2018-07-10 Ryosuke Niwa <[email protected]>
+
+ Disable cross-origin-window-policy by default
+ https://bugs.webkit.org/show_bug.cgi?id=187509
+
+ Reviewed by Chris Dumez.
+
+ Disabled the feature by default.
+
+ * page/Settings.yaml:
+
2018-07-10 Alejandro G. Castro <[email protected]>
[GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC is not needed anymore
Modified: trunk/Source/WebCore/page/Settings.yaml (233686 => 233687)
--- trunk/Source/WebCore/page/Settings.yaml 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebCore/page/Settings.yaml 2018-07-10 16:53:39 UTC (rev 233687)
@@ -745,7 +745,7 @@
onChange: setNeedsRecalcStyleInAllFrames
crossOriginWindowPolicySupportEnabled:
- initial: true
+ initial: false
accessibilityEventsEnabled:
initial: true
Modified: trunk/Source/WebKit/ChangeLog (233686 => 233687)
--- trunk/Source/WebKit/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKit/ChangeLog 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1,3 +1,16 @@
+2018-07-10 Ryosuke Niwa <[email protected]>
+
+ Disable cross-origin-window-policy by default
+ https://bugs.webkit.org/show_bug.cgi?id=187509
+
+ Reviewed by Chris Dumez.
+
+ * Shared/WebPreferences.yaml:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetCrossOriginWindowPolicyEnabled):
+ (WKPreferencesGetCrossOriginWindowPolicyEnabled):
+ * UIProcess/API/C/WKPreferencesRef.h:
+
2018-07-09 Tim Horton <[email protected]>
REGRESSION (r232416): Flickering when going back to Google search results on back swipe
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (233686 => 233687)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1059,7 +1059,7 @@
CrossOriginWindowPolicySupportEnabled:
type: bool
- defaultValue: true
+ defaultValue: false
SubresourceIntegrityEnabled:
type: bool
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (233686 => 233687)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1984,6 +1984,16 @@
return toImpl(preferencesRef)->crossOriginResourcePolicyEnabled();
}
+void WKPreferencesSetCrossOriginWindowPolicyEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setCrossOriginWindowPolicySupportEnabled(enabled);
+}
+
+bool WKPreferencesGetCrossOriginWindowPolicyEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->crossOriginWindowPolicySupportEnabled();
+}
+
void WKPreferencesSetRestrictedHTTPResponseAccess(WKPreferencesRef preferencesRef, bool flag)
{
toImpl(preferencesRef)->setRestrictedHTTPResponseAccess(flag);
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h (233686 => 233687)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h 2018-07-10 16:53:39 UTC (rev 233687)
@@ -323,6 +323,10 @@
WK_EXPORT bool WKPreferencesGetCrossOriginResourcePolicyEnabled(WKPreferencesRef preferencesRef);
WK_EXPORT void WKPreferencesSetCrossOriginResourcePolicyEnabled(WKPreferencesRef preferencesRef, bool allow);
+// Defaults to false.
+WK_EXPORT bool WKPreferencesGetCrossOriginWindowPolicyEnabled(WKPreferencesRef preferencesRef);
+WK_EXPORT void WKPreferencesSetCrossOriginWindowPolicyEnabled(WKPreferencesRef preferencesRef, bool enabled);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (233686 => 233687)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1,3 +1,13 @@
+2018-07-10 Ryosuke Niwa <[email protected]>
+
+ Disable cross-origin-window-policy by default
+ https://bugs.webkit.org/show_bug.cgi?id=187509
+
+ Reviewed by Chris Dumez.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+
2018-07-09 Timothy Hatcher <[email protected]>
Semantic colors don't update when accessibility Increase Contrast mode is enabled.
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (233686 => 233687)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-07-10 16:53:39 UTC (rev 233687)
@@ -634,7 +634,7 @@
[NSNumber numberWithBool:NO], WebKitWebGPUEnabledPreferenceKey,
#endif
[NSNumber numberWithBool:NO], WebKitCacheAPIEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey,
+ [NSNumber numberWithBool:NO], WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitFetchAPIEnabledPreferenceKey,
#if ENABLE(STREAMS_API)
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (233686 => 233687)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1,3 +1,13 @@
+2018-07-10 Ryosuke Niwa <[email protected]>
+
+ Disable cross-origin-window-policy by default
+ https://bugs.webkit.org/show_bug.cgi?id=187509
+
+ Reviewed by Chris Dumez.
+
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+
2018-06-23 Yusuke Suzuki <[email protected]>
[WTF] Add user-defined literal for ASCIILiteral
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (233686 => 233687)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-07-10 16:53:39 UTC (rev 233687)
@@ -249,7 +249,7 @@
CFDictionaryAddValue(defaults, CFSTR(WebKitShouldDisplaySubtitlesPreferenceKey), kCFBooleanFalse);
CFDictionaryAddValue(defaults, CFSTR(WebKitShouldDisplayCaptionsPreferenceKey), kCFBooleanFalse);
CFDictionaryAddValue(defaults, CFSTR(WebKitShouldDisplayTextDescriptionsPreferenceKey), kCFBooleanFalse);
- CFDictionaryAddValue(defaults, CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey), kCFBooleanTrue);
+ CFDictionaryAddValue(defaults, CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey), kCFBooleanFalse);
RetainPtr<CFStringRef> linkBehaviorStringRef = adoptCF(CFStringCreateWithFormat(0, 0, CFSTR("%d"), WebKitEditableLinkDefaultBehavior));
CFDictionaryAddValue(defaults, CFSTR(WebKitEditableLinkBehaviorPreferenceKey), linkBehaviorStringRef.get());
Modified: trunk/Tools/ChangeLog (233686 => 233687)
--- trunk/Tools/ChangeLog 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Tools/ChangeLog 2018-07-10 16:53:39 UTC (rev 233687)
@@ -1,3 +1,15 @@
+2018-07-10 Ryosuke Niwa <[email protected]>
+
+ Disable cross-origin-window-policy by default
+ https://bugs.webkit.org/show_bug.cgi?id=187509
+
+ Reviewed by Chris Dumez.
+
+ Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
2018-07-10 Thibault Saunier <[email protected]>
[Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (233686 => 233687)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2018-07-10 16:44:45 UTC (rev 233686)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2018-07-10 16:53:39 UTC (rev 233687)
@@ -772,6 +772,7 @@
WKPreferencesSetAccessibilityObjectModelEnabled(preferences, true);
WKPreferencesSetMediaCapabilitiesEnabled(preferences, true);
+ WKPreferencesSetCrossOriginWindowPolicyEnabled(preferences, true);
WKPreferencesSetRestrictedHTTPResponseAccess(preferences, true);
WKPreferencesSetServerTimingEnabled(preferences, true);
