Title: [234229] branches/safari-606-branch/Source/WebKit
- Revision
- 234229
- Author
- [email protected]
- Date
- 2018-07-26 00:14:05 -0700 (Thu, 26 Jul 2018)
Log Message
Cherry-pick r234023. rdar://problem/42451655
Null pointer dereference under WebPage::autofillLoginCredentials()
https://bugs.webkit.org/show_bug.cgi?id=187823
<rdar://problem/37152195>
Reviewed by David Kilzer.
Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autofillLoginCredentials):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (234228 => 234229)
--- branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-26 03:34:57 UTC (rev 234228)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-26 07:14:05 UTC (rev 234229)
@@ -1,3 +1,34 @@
+2018-07-25 Babak Shafiei <[email protected]>
+
+ Cherry-pick r234023. rdar://problem/42451655
+
+ Null pointer dereference under WebPage::autofillLoginCredentials()
+ https://bugs.webkit.org/show_bug.cgi?id=187823
+ <rdar://problem/37152195>
+
+ Reviewed by David Kilzer.
+
+ Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::autofillLoginCredentials):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-19 Chris Dumez <[email protected]>
+
+ Null pointer dereference under WebPage::autofillLoginCredentials()
+ https://bugs.webkit.org/show_bug.cgi?id=187823
+ <rdar://problem/37152195>
+
+ Reviewed by David Kilzer.
+
+ Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::autofillLoginCredentials):
+
2018-07-20 Babak Shafiei <[email protected]>
Revert r233925. rdar://problem/42354959
Modified: branches/safari-606-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (234228 => 234229)
--- branches/safari-606-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2018-07-26 03:34:57 UTC (rev 234228)
+++ branches/safari-606-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2018-07-26 07:14:05 UTC (rev 234229)
@@ -2465,7 +2465,7 @@
void WebPage::autofillLoginCredentials(const String& username, const String& password)
{
- if (is<HTMLInputElement>(*m_assistedNode)) {
+ if (is<HTMLInputElement>(m_assistedNode.get())) {
if (auto autofillElements = AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode)))
autofillElements->autofill(username, password);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
