Title: [234230] branches/safari-606-branch/Source/WebCore
- Revision
- 234230
- Author
- [email protected]
- Date
- 2018-07-26 00:14:09 -0700 (Thu, 26 Jul 2018)
Log Message
Cherry-pick r234053. rdar://problem/42451651
Update FrameView::paintContents to use release logging.
https://bugs.webkit.org/show_bug.cgi?id=187854
<rdar://problem/42432371>
Reviewed by Simon Fraser.
Adding release logging helps identifying blank content cases.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (234229 => 234230)
--- branches/safari-606-branch/Source/WebCore/ChangeLog 2018-07-26 07:14:05 UTC (rev 234229)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog 2018-07-26 07:14:09 UTC (rev 234230)
@@ -1,5 +1,36 @@
2018-07-25 Babak Shafiei <[email protected]>
+ Cherry-pick r234053. rdar://problem/42451651
+
+ Update FrameView::paintContents to use release logging.
+ https://bugs.webkit.org/show_bug.cgi?id=187854
+ <rdar://problem/42432371>
+
+ Reviewed by Simon Fraser.
+
+ Adding release logging helps identifying blank content cases.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-20 Zalan Bujtas <[email protected]>
+
+ Update FrameView::paintContents to use release logging.
+ https://bugs.webkit.org/show_bug.cgi?id=187854
+ <rdar://problem/42432371>
+
+ Reviewed by Simon Fraser.
+
+ Adding release logging helps identifying blank content cases.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
+2018-07-25 Babak Shafiei <[email protected]>
+
Cherry-pick r234177. rdar://problem/42586717
Unreviewed, rolling out r233496 and r233571.
Modified: branches/safari-606-branch/Source/WebCore/page/FrameView.cpp (234229 => 234230)
--- branches/safari-606-branch/Source/WebCore/page/FrameView.cpp 2018-07-26 07:14:05 UTC (rev 234229)
+++ branches/safari-606-branch/Source/WebCore/page/FrameView.cpp 2018-07-26 07:14:09 UTC (rev 234230)
@@ -118,6 +118,8 @@
#include "LegacyTileCache.h"
#endif
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(frame().page() && frame().page()->isAlwaysOnLoggingAllowed(), Layout, "%p - FrameView::" fmt, this, ##__VA_ARGS__)
+
namespace WebCore {
using namespace HTMLNames;
@@ -4140,8 +4142,10 @@
return;
ASSERT(!needsLayout());
- if (needsLayout())
+ if (needsLayout()) {
+ RELEASE_LOG_IF_ALLOWED("FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)", frame().isMainFrame());
return;
+ }
PaintingState paintingState;
willPaintContents(context, dirtyRect, paintingState);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
