Title: [235612] trunk/Source/_javascript_Core
Revision
235612
Author
[email protected]
Date
2018-09-04 07:48:55 -0700 (Tue, 04 Sep 2018)

Log Message

[WPE][GTK] Add more unused result warnings to JSC API
https://bugs.webkit.org/show_bug.cgi?id=189243

Reviewed by Carlos Garcia Campos.

The jsc_context_evaluate() family of functions has a (transfer full) return value, but the
caller may be tempted to not inspect it if uninterested in the return value. This would be
an error, because it must be freed.

* API/glib/JSCContext.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/glib/JSCContext.h (235611 => 235612)


--- trunk/Source/_javascript_Core/API/glib/JSCContext.h	2018-09-04 12:10:34 UTC (rev 235611)
+++ trunk/Source/_javascript_Core/API/glib/JSCContext.h	2018-09-04 14:48:55 UTC (rev 235612)
@@ -135,7 +135,7 @@
 JSC_API JSCValue *
 jsc_context_evaluate                 (JSCContext         *context,
                                       const char         *code,
-                                      gssize              length);
+                                      gssize              length) G_GNUC_WARN_UNUSED_RESULT;
 
 JSC_API JSCValue *
 jsc_context_evaluate_with_source_uri (JSCContext         *context,
@@ -142,7 +142,7 @@
                                       const char         *code,
                                       gssize              length,
                                       const char         *uri,
-                                      guint               line_number);
+                                      guint               line_number) G_GNUC_WARN_UNUSED_RESULT;
 
 JSC_API JSCValue *
 jsc_context_evaluate_in_object       (JSCContext         *context,
@@ -152,7 +152,7 @@
                                       JSCClass           *object_class,
                                       const char         *uri,
                                       guint               line_number,
-                                      JSCValue          **object);
+                                      JSCValue          **object) G_GNUC_WARN_UNUSED_RESULT;
 
 JSC_API JSCCheckSyntaxResult
 jsc_context_check_syntax             (JSCContext         *context,

Modified: trunk/Source/_javascript_Core/ChangeLog (235611 => 235612)


--- trunk/Source/_javascript_Core/ChangeLog	2018-09-04 12:10:34 UTC (rev 235611)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-09-04 14:48:55 UTC (rev 235612)
@@ -1,3 +1,16 @@
+2018-09-04  Michael Catanzaro  <[email protected]>
+
+        [WPE][GTK] Add more unused result warnings to JSC API
+        https://bugs.webkit.org/show_bug.cgi?id=189243
+
+        Reviewed by Carlos Garcia Campos.
+
+        The jsc_context_evaluate() family of functions has a (transfer full) return value, but the
+        caller may be tempted to not inspect it if uninterested in the return value. This would be
+        an error, because it must be freed.
+
+        * API/glib/JSCContext.h:
+
 2018-09-03  Mark Lam  <[email protected]>
 
         The watchdog sometimes fails to terminate a script.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to