Title: [235614] trunk/Tools
- Revision
- 235614
- Author
- [email protected]
- Date
- 2018-09-04 10:01:55 -0700 (Tue, 04 Sep 2018)
Log Message
REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=187972
<rdar://problem/42667737>
Reviewed by Darin Adler.
Ensure that listeners are added in time to catch messages broadcast at them.
* TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235613 => 235614)
--- trunk/Tools/ChangeLog 2018-09-04 16:55:46 UTC (rev 235613)
+++ trunk/Tools/ChangeLog 2018-09-04 17:01:55 UTC (rev 235614)
@@ -1,3 +1,16 @@
+2018-09-04 Jer Noble <[email protected]>
+
+ REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=187972
+ <rdar://problem/42667737>
+
+ Reviewed by Darin Adler.
+
+ Ensure that listeners are added in time to catch messages broadcast at them.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
+ (TestWebKitAPI::TEST):
+
2018-09-04 Ross Kirsling <[email protected]>
Update googletest
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm (235613 => 235614)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm 2018-09-04 16:55:46 UTC (rev 235613)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm 2018-09-04 17:01:55 UTC (rev 235614)
@@ -333,7 +333,6 @@
[webView loadTestPageNamed:@"play-audio-on-click"];
[webView waitForPageToLoadWithAutoplayingVideos:0];
- [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
[webView performAfterReceivingMessage:@"playing-first" action:^ {
[webView evaluateJavaScript:@"seekToEnd()" completionHandler:nil];
@@ -343,6 +342,9 @@
[webView performAfterReceivingMessage:@"playing-second" action:^ {
secondAudioPlaying = true;
}];
+
+ [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
+
TestWebKitAPI::Util::run(&secondAudioPlaying);
while ([[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]]) {
if ([webView _hasActiveVideoForControlsManager] && [[webView controlledElementID] isEqualToString:@"second"])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes