Title: [235674] trunk/Source/WebKit
Revision
235674
Author
[email protected]
Date
2018-09-05 10:11:25 -0700 (Wed, 05 Sep 2018)

Log Message

Cancelled fullscreen exit gesture leaves bad state for next exit request.
https://bugs.webkit.org/show_bug.cgi?id=189278

Patch by Jeremy Jones <[email protected]> on 2018-09-05
Reviewed by Jer Noble.

* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _dismissFullscreenViewController]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (235673 => 235674)


--- trunk/Source/WebKit/ChangeLog	2018-09-05 17:03:02 UTC (rev 235673)
+++ trunk/Source/WebKit/ChangeLog	2018-09-05 17:11:25 UTC (rev 235674)
@@ -1,3 +1,13 @@
+2018-09-05  Jeremy Jones  <[email protected]>
+
+        Cancelled fullscreen exit gesture leaves bad state for next exit request.
+        https://bugs.webkit.org/show_bug.cgi?id=189278
+
+        Reviewed by Jer Noble.
+
+        * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
+        (-[WKFullScreenWindowController _dismissFullscreenViewController]):
+
 2018-09-05  Eric Carlson  <[email protected]>
 
         [MediaStream] Simplify logic when changing RealtimeMediaSource settings

Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm (235673 => 235674)


--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm	2018-09-05 17:03:02 UTC (rev 235673)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm	2018-09-05 17:11:25 UTC (rev 235674)
@@ -977,15 +977,12 @@
         if (![self._webView _page])
             return;
 
-
-        if (_interactiveDismissTransitionCoordinator.get().animator.context.transitionWasCancelled) {
+        if (_interactiveDismissTransitionCoordinator.get().animator.context.transitionWasCancelled)
             [_fullscreenViewController setAnimating:NO];
-            return;
-        }
-
+        else
+            [self _completedExitFullScreen];
+        
         _interactiveDismissTransitionCoordinator = nil;
-
-        [self _completedExitFullScreen];
     }];
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to