Diff
Modified: trunk/Source/WebCore/ChangeLog (235674 => 235675)
--- trunk/Source/WebCore/ChangeLog 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/ChangeLog 2018-09-05 17:26:54 UTC (rev 235675)
@@ -1,3 +1,20 @@
+2018-09-05 Jer Noble <[email protected]>
+
+ Add MediaCapabilities as an Experimental Feature
+ https://bugs.webkit.org/show_bug.cgi?id=189209
+
+ Reviewed by Eric Carlson.
+
+ Move mediaCapabilitiesEnabled out of RuntimeEnabledFeatures. It already (also) exists in Settings.
+
+ * Modules/mediacapabilities/MediaCapabilities.idl:
+ * Modules/mediacapabilities/MediaCapabilitiesInfo.idl:
+ * Modules/mediacapabilities/NavigatorMediaCapabilities.idl:
+ * Modules/mediacapabilities/ScreenLuminance.idl:
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setMediaCapabilitiesEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::mediaCapabilitiesEnabled const): Deleted.
+
2018-09-05 Woodrow Wang <[email protected]>
Add functionality to encode and decode a uint64_t in KeyedCoding
Modified: trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl (235674 => 235675)
--- trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl 2018-09-05 17:26:54 UTC (rev 235675)
@@ -24,7 +24,7 @@
*/
[
- EnabledAtRuntime=MediaCapabilities,
+ EnabledBySetting=MediaCapabilities,
ImplementationLacksVTable
]
interface MediaCapabilities {
Modified: trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl (235674 => 235675)
--- trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl 2018-09-05 17:26:54 UTC (rev 235675)
@@ -24,7 +24,7 @@
*/
[
- EnabledAtRuntime=MediaCapabilities,
+ EnabledBySetting=MediaCapabilities,
ImplementationLacksVTable
]
interface MediaCapabilitiesInfo {
Modified: trunk/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl (235674 => 235675)
--- trunk/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl 2018-09-05 17:26:54 UTC (rev 235675)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-[ EnabledAtRuntime=MediaCapabilities ]
+[ EnabledBySetting=MediaCapabilities ]
partial interface Navigator {
[SameObject] readonly attribute MediaCapabilities mediaCapabilities;
};
Modified: trunk/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl (235674 => 235675)
--- trunk/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl 2018-09-05 17:26:54 UTC (rev 235675)
@@ -24,7 +24,7 @@
*/
[
- EnabledAtRuntime=MediaCapabilities,
+ EnabledBySetting=MediaCapabilities,
ImplementationLacksVTable
]
interface ScreenLuminance {
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (235674 => 235675)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-09-05 17:26:54 UTC (rev 235675)
@@ -250,9 +250,6 @@
void setAriaReflectionEnabled(bool isEnabled) { m_ariaReflectionEnabled = isEnabled; }
bool ariaReflectionEnabled() const { return m_ariaReflectionEnabled; }
- void setMediaCapabilitiesEnabled(bool isEnabled) { m_mediaCapabilitiesEnabled = isEnabled; }
- bool mediaCapabilitiesEnabled() const { return m_mediaCapabilitiesEnabled; }
-
void setResourceLoadStatisticsDebugMode(bool isEnabled) { m_resourceLoadStatisticsDebugMode = isEnabled; }
bool resourceLoadStatisticsDebugMode() const { return m_resourceLoadStatisticsDebugMode; }
@@ -413,7 +410,6 @@
bool m_webVREnabled { false };
bool m_accessibilityObjectModelEnabled { false };
bool m_ariaReflectionEnabled { true };
- bool m_mediaCapabilitiesEnabled { false };
bool m_resourceLoadStatisticsDebugMode { false };
bool m_isRestrictedHTTPResponseAccess { true };
bool m_crossOriginResourcePolicyEnabled { true };
Modified: trunk/Source/WebKit/ChangeLog (235674 => 235675)
--- trunk/Source/WebKit/ChangeLog 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebKit/ChangeLog 2018-09-05 17:26:54 UTC (rev 235675)
@@ -1,3 +1,12 @@
+2018-09-05 Jer Noble <[email protected]>
+
+ Add MediaCapabilities as an Experimental Feature
+ https://bugs.webkit.org/show_bug.cgi?id=189209
+
+ Reviewed by Eric Carlson.
+
+ * Shared/WebPreferences.yaml:
+
2018-09-05 Jeremy Jones <[email protected]>
Cancelled fullscreen exit gesture leaves bad state for next exit request.
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (235674 => 235675)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-05 17:26:54 UTC (rev 235675)
@@ -1047,8 +1047,10 @@
MediaCapabilitiesEnabled:
type: bool
- defaultValue: false
- webcoreBinding: RuntimeEnabledFeatures
+ defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
+ humanReadableName: "Media Capabilities API"
+ humanReadableDescription: "Media Capabilities API"
+ category: experimental
SystemPreviewEnabled:
type: bool
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (235674 => 235675)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-09-05 17:26:54 UTC (rev 235675)
@@ -1,3 +1,15 @@
+2018-09-05 Jer Noble <[email protected]>
+
+ Add MediaCapabilities as an Experimental Feature
+ https://bugs.webkit.org/show_bug.cgi?id=189209
+
+ Reviewed by Eric Carlson.
+
+ RuntimeEnabledFeature -> Setting.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2018-09-04 Frederic Wang <[email protected]>
Add basic support for ScrollIntoViewOptions
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (235674 => 235675)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-09-05 17:11:25 UTC (rev 235674)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-09-05 17:26:54 UTC (rev 235675)
@@ -3125,7 +3125,6 @@
RuntimeEnabledFeatures::sharedFeatures().setMenuItemElementEnabled([preferences menuItemElementEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setAccessibilityObjectModelEnabled([preferences accessibilityObjectModelEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setAriaReflectionEnabled([preferences ariaReflectionEnabled]);
- RuntimeEnabledFeatures::sharedFeatures().setMediaCapabilitiesEnabled([preferences mediaCapabilitiesEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setFetchAPIKeepAliveEnabled([preferences fetchAPIKeepAliveEnabled]);
#if ENABLE(LEGACY_ENCRYPTED_MEDIA)
@@ -3170,6 +3169,7 @@
settings.setLargeImageAsyncDecodingEnabled([preferences largeImageAsyncDecodingEnabled]);
settings.setAnimatedImageAsyncDecodingEnabled([preferences animatedImageAsyncDecodingEnabled]);
+ settings.setMediaCapabilitiesEnabled([preferences mediaCapabilitiesEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setServerTimingEnabled([preferences serverTimingEnabled]);
}
