Title: [236248] trunk/Source/_javascript_Core
- Revision
- 236248
- Author
- [email protected]
- Date
- 2018-09-20 00:43:15 -0700 (Thu, 20 Sep 2018)
Log Message
[Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
https://bugs.webkit.org/show_bug.cgi?id=189730
Reviewed by Saam Barati.
Clang for Windows can't compile the workaround for MSVC quirk in generateOutOfLine.
* jit/JITMathIC.h:
(generateOutOfLine): Append "&& !COMPILER(CLANG)" to "#if COMPILER(MSVC)".
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236247 => 236248)
--- trunk/Source/_javascript_Core/ChangeLog 2018-09-20 07:33:42 UTC (rev 236247)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-09-20 07:43:15 UTC (rev 236248)
@@ -1,3 +1,15 @@
+2018-09-20 Fujii Hironori <[email protected]>
+
+ [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
+ https://bugs.webkit.org/show_bug.cgi?id=189730
+
+ Reviewed by Saam Barati.
+
+ Clang for Windows can't compile the workaround for MSVC quirk in generateOutOfLine.
+
+ * jit/JITMathIC.h:
+ (generateOutOfLine): Append "&& !COMPILER(CLANG)" to "#if COMPILER(MSVC)".
+
2018-09-19 Yusuke Suzuki <[email protected]>
[JSC] Optimize Array#indexOf in C++ runtime
Modified: trunk/Source/_javascript_Core/jit/JITMathIC.h (236247 => 236248)
--- trunk/Source/_javascript_Core/jit/JITMathIC.h 2018-09-20 07:33:42 UTC (rev 236247)
+++ trunk/Source/_javascript_Core/jit/JITMathIC.h 2018-09-20 07:43:15 UTC (rev 236248)
@@ -144,7 +144,7 @@
};
auto replaceCall = [&] () {
-#if COMPILER(MSVC)
+#if COMPILER(MSVC) && !COMPILER(CLANG)
ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().retagged<JSInternalPtrTag>(), callReplacement);
#else
ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().template retagged<JSInternalPtrTag>(), callReplacement);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
