Title: [236251] releases/WebKitGTK/webkit-2.22/Source/WebKit
- Revision
- 236251
- Author
- [email protected]
- Date
- 2018-09-20 00:54:24 -0700 (Thu, 20 Sep 2018)
Log Message
Merge r236245 - [GTK] Always prints in portrait when landscape is requested
https://bugs.webkit.org/show_bug.cgi?id=189543
Patch by Tomas Popela <[email protected]> on 2018-09-20
Reviewed by Michael Catanzaro.
We have to change the surface size based on the requested orientation.
Otherwise only portrait will be printed as it's hardcoded.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (236250 => 236251)
--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog 2018-09-20 07:54:20 UTC (rev 236250)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog 2018-09-20 07:54:24 UTC (rev 236251)
@@ -1,3 +1,15 @@
+2018-09-20 Tomas Popela <[email protected]>
+
+ [GTK] Always prints in portrait when landscape is requested
+ https://bugs.webkit.org/show_bug.cgi?id=189543
+
+ Reviewed by Michael Catanzaro.
+
+ We have to change the surface size based on the requested orientation.
+ Otherwise only portrait will be printed as it's hardcoded.
+
+ * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
+
2018-09-11 Pablo Saavedra <[email protected]>
Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp
Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp (236250 => 236251)
--- releases/WebKitGTK/webkit-2.22/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2018-09-20 07:54:20 UTC (rev 236250)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2018-09-20 07:54:24 UTC (rev 236251)
@@ -134,7 +134,16 @@
break;
}
} else if (surfaceType == CAIRO_SURFACE_TYPE_PDF)
- cairo_pdf_surface_set_size(surface, width, height);
+ switch (gtk_page_setup_get_orientation(m_pageSetup.get())) {
+ case GTK_PAGE_ORIENTATION_PORTRAIT:
+ case GTK_PAGE_ORIENTATION_REVERSE_PORTRAIT:
+ cairo_pdf_surface_set_size(surface, width, height);
+ break;
+ case GTK_PAGE_ORIENTATION_LANDSCAPE:
+ case GTK_PAGE_ORIENTATION_REVERSE_LANDSCAPE:
+ cairo_pdf_surface_set_size(surface, height, width);
+ break;
+ }
}
void endPage(cairo_t* cr) override
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
