Title: [236898] trunk
- Revision
- 236898
- Author
- [email protected]
- Date
- 2018-10-06 09:07:18 -0700 (Sat, 06 Oct 2018)
Log Message
[Xcode] Never build yasm with ASAN
https://bugs.webkit.org/show_bug.cgi?id=190327
Reviewed by Youenn Fablet.
Source/ThirdParty/libwebrtc:
* Configurations/yasm.xcconfig: Set WK_ASAN_DISALLOWED to YES.
Tools:
* asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (236897 => 236898)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-10-06 15:59:39 UTC (rev 236897)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-10-06 16:07:18 UTC (rev 236898)
@@ -1,5 +1,14 @@
2018-10-06 Dan Bernstein <[email protected]>
+ [Xcode] Never build yasm with ASAN
+ https://bugs.webkit.org/show_bug.cgi?id=190327
+
+ Reviewed by Youenn Fablet.
+
+ * Configurations/yasm.xcconfig: Set WK_ASAN_DISALLOWED to YES.
+
+2018-10-06 Dan Bernstein <[email protected]>
+
Fixed iOS device production builds after r236896.
* Configurations/yasm.xcconfig: Excluding all sources when building for an iOS device meant
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig (236897 => 236898)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig 2018-10-06 15:59:39 UTC (rev 236897)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig 2018-10-06 16:07:18 UTC (rev 236898)
@@ -19,3 +19,5 @@
EXCLUDED_SOURCE_FILE_NAMES[sdk=macos*] = *_neon.c arm_cpudetect.c *_arm.c sad.c;
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphonesimulator*] = *_neon.c arm_cpudetect.c *_arm.c sad.c;
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphoneos*] = *_sse2.c *_ssse3.c *_sse4.c *_avx2.c *_avx.c *_sse2.asm.o *_sse3.asm.o;
+
+WK_ASAN_DISALLOWED = YES;
Modified: trunk/Tools/ChangeLog (236897 => 236898)
--- trunk/Tools/ChangeLog 2018-10-06 15:59:39 UTC (rev 236897)
+++ trunk/Tools/ChangeLog 2018-10-06 16:07:18 UTC (rev 236898)
@@ -1,3 +1,13 @@
+2018-10-06 Dan Bernstein <[email protected]>
+
+ [Xcode] Never build yasm with ASAN
+ https://bugs.webkit.org/show_bug.cgi?id=190327
+
+ Reviewed by Youenn Fablet.
+
+ * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
+ the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
+
2018-10-05 Chris Dumez <[email protected]>
Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
Modified: trunk/Tools/asan/asan.xcconfig (236897 => 236898)
--- trunk/Tools/asan/asan.xcconfig 2018-10-06 15:59:39 UTC (rev 236897)
+++ trunk/Tools/asan/asan.xcconfig 2018-10-06 16:07:18 UTC (rev 236898)
@@ -11,7 +11,9 @@
GCC_OPTIMIZATION_LEVEL_Production = 1;
GCC_OPTIMIZATION_LEVEL_Release = 1;
-CLANG_ADDRESS_SANITIZER=YES
+CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_DISALLOWED));
+CLANG_ADDRESS_SANITIZER_ = YES;
+CLANG_ADDRESS_SANITIZER_NO = YES;
ASAN_OTHER_CFLAGS = -fno-omit-frame-pointer -g;
ASAN_OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CFLAGS);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
