[webkit-changes] [236899] trunk/Source/WTF

[mark . lam]

Title: [236899] trunk/Source/WTF

Revision

236899

Author

mark....@apple.com

Date

2018-10-06 12:10:31 -0700 (Sat, 06 Oct 2018)

Log Message

Adding some temporary asserts to debug a mysterious ASAN bot crash.
https://bugs.webkit.org/show_bug.cgi?id=190331

Reviewed by Filip Pizlo.

These assertions are needed because we can't reproduce the issue locally.
We'll remove these asserts after the needed data has been collected from the bot.

* wtf/StackBounds.h:
(WTF::StackBounds::checkConsistency const):

Modified Paths

• trunk/Source/WTF/ChangeLog
• trunk/Source/WTF/wtf/StackBounds.h

Diff

Modified: trunk/Source/WTF/ChangeLog (236898 => 236899)

--- trunk/Source/WTF/ChangeLog	2018-10-06 16:07:18 UTC (rev 236898)
+++ trunk/Source/WTF/ChangeLog	2018-10-06 19:10:31 UTC (rev 236899)
@@ -1,3 +1,16 @@
+2018-10-06  Mark Lam  <mark....@apple.com>
+
+        Adding some temporary asserts to debug a mysterious ASAN bot crash.
+        https://bugs.webkit.org/show_bug.cgi?id=190331
+
+        Reviewed by Filip Pizlo.
+
+        These assertions are needed because we can't reproduce the issue locally.
+        We'll remove these asserts after the needed data has been collected from the bot.
+
+        * wtf/StackBounds.h:
+        (WTF::StackBounds::checkConsistency const):
+
 2018-10-05  Yusuke Suzuki  <yusukesuz...@slowstart.org>
 
         [JSC][Linux] Support Perf JITDump logging

Modified: trunk/Source/WTF/wtf/StackBounds.h (236898 => 236899)

--- trunk/Source/WTF/wtf/StackBounds.h	2018-10-06 16:07:18 UTC (rev 236898)
+++ trunk/Source/WTF/wtf/StackBounds.h	2018-10-06 19:10:31 UTC (rev 236899)
@@ -147,6 +147,26 @@
     {
 #if !ASSERT_DISABLED
         void* currentPosition = &currentPosition;
+
+        // The following set of assertions are only needed for debugging a
+        // mysterious crash on an ASAN bot that is not reproducible otherwise.
+        // Will remove after the needed data has been collected.
+#if OS(LINUX)
+        ASSERT(currentPosition);
+        ASSERT(m_origin);
+        ASSERT(m_bound);
+        ASSERT(currentPosition != m_origin);
+        ASSERT(currentPosition != m_bound);
+        if (isGrowingDownward()) {
+            ASSERT(currentPosition < m_origin);
+            ASSERT(currentPosition > m_bound);
+        } else {
+            ASSERT(currentPosition > m_origin);
+            ASSERT(currentPosition < m_bound);
+        }
+#endif // OS(LINUX)
+        // End of ASAN bot debugging assertions.
+
         ASSERT(m_origin != m_bound);
         ASSERT(isGrowingDownward()
             ? (currentPosition < m_origin && currentPosition > m_bound)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes