Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (237109 => 237110)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-15 15:23:59 UTC (rev 237110)
@@ -1,3 +1,12 @@
+2018-10-15 Alex Christensen <[email protected]>
+
+ Shrink more enum classes
+ https://bugs.webkit.org/show_bug.cgi?id=190540
+
+ Reviewed by Chris Dumez.
+
+ * runtime/ConsoleTypes.h:
+
2018-10-15 Yusuke Suzuki <[email protected]>
[JSC] Disable DOMJIT on 32bit architecture
Modified: trunk/Source/_javascript_Core/runtime/ConsoleTypes.h (237109 => 237110)
--- trunk/Source/_javascript_Core/runtime/ConsoleTypes.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/_javascript_Core/runtime/ConsoleTypes.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace JSC {
-enum class MessageSource {
+enum class MessageSource : uint8_t {
XML,
JS,
Network,
@@ -61,7 +61,7 @@
ProfileEnd,
};
-enum class MessageLevel {
+enum class MessageLevel : uint8_t {
Log = 1,
Warning = 2,
Error = 3,
Modified: trunk/Source/WebCore/ChangeLog (237109 => 237110)
--- trunk/Source/WebCore/ChangeLog 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/ChangeLog 2018-10-15 15:23:59 UTC (rev 237110)
@@ -1,3 +1,34 @@
+2018-10-15 Alex Christensen <[email protected]>
+
+ Shrink more enum classes
+ https://bugs.webkit.org/show_bug.cgi?id=190540
+
+ Reviewed by Chris Dumez.
+
+ * Modules/notifications/NotificationDirection.h:
+ * dom/Document.h:
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+ * loader/HistoryController.h:
+ * loader/ShouldSkipSafeBrowsingCheck.h:
+ * loader/ShouldTreatAsContinuingLoad.h:
+ * page/AutoplayEvent.h:
+ * page/ChromeClient.h:
+ * page/DiagnosticLoggingClient.h:
+ * page/Page.h:
+ * platform/CookiesStrategy.h:
+ * platform/audio/AudioSession.h:
+ * platform/network/NetworkStorageSession.h:
+ * platform/network/StoredCredentialsPolicy.h:
+ * workers/service/SWClientConnection.h:
+ * workers/service/ServiceWorkerContainer.h:
+ * workers/service/ServiceWorkerRegistrationData.h:
+ * workers/service/ServiceWorkerRegistrationOptions.h:
+ * workers/service/ServiceWorkerTypes.h:
+ * workers/service/ServiceWorkerUpdateViaCache.h:
+ * workers/service/server/SWServer.h:
+ * workers/service/server/SWServerRegistration.h:
+
2018-10-15 Patrick Griffis <[email protected]>
[GTK][WPE] Implement subprocess sandboxing
Modified: trunk/Source/WebCore/Modules/notifications/NotificationDirection.h (237109 => 237110)
--- trunk/Source/WebCore/Modules/notifications/NotificationDirection.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/Modules/notifications/NotificationDirection.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -27,7 +27,7 @@
namespace WebCore {
-enum class NotificationDirection {
+enum class NotificationDirection : uint8_t {
Auto,
Ltr,
Rtl
Modified: trunk/Source/WebCore/dom/Document.h (237109 => 237110)
--- trunk/Source/WebCore/dom/Document.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/dom/Document.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -202,7 +202,7 @@
enum CollectionType;
enum class ShouldOpenExternalURLsPolicy : uint8_t;
-enum class RouteSharingPolicy;
+enum class RouteSharingPolicy : uint8_t;
using PlatformDisplayID = uint32_t;
Modified: trunk/Source/WebCore/loader/FrameLoader.h (237109 => 237110)
--- trunk/Source/WebCore/loader/FrameLoader.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/loader/FrameLoader.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -84,7 +84,7 @@
class SubstituteData;
enum class ShouldContinue;
-enum class ShouldTreatAsContinuingLoad;
+enum class ShouldTreatAsContinuingLoad : bool;
struct WindowFeatures;
Modified: trunk/Source/WebCore/loader/FrameLoaderClient.h (237109 => 237110)
--- trunk/Source/WebCore/loader/FrameLoaderClient.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/loader/FrameLoaderClient.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -104,7 +104,7 @@
class Widget;
enum class PolicyDecisionMode;
-enum class ShouldSkipSafeBrowsingCheck;
+enum class ShouldSkipSafeBrowsingCheck : bool;
struct StringWithDirection;
Modified: trunk/Source/WebCore/loader/HistoryController.h (237109 => 237110)
--- trunk/Source/WebCore/loader/HistoryController.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/loader/HistoryController.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -40,7 +40,7 @@
class HistoryItem;
class SerializedScriptValue;
-enum class ShouldTreatAsContinuingLoad;
+enum class ShouldTreatAsContinuingLoad : bool;
struct StringWithDirection;
Modified: trunk/Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h (237109 => 237110)
--- trunk/Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebCore {
-enum class ShouldSkipSafeBrowsingCheck { No, Yes };
+enum class ShouldSkipSafeBrowsingCheck : bool { No, Yes };
}
Modified: trunk/Source/WebCore/loader/ShouldTreatAsContinuingLoad.h (237109 => 237110)
--- trunk/Source/WebCore/loader/ShouldTreatAsContinuingLoad.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/loader/ShouldTreatAsContinuingLoad.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebCore {
-enum class ShouldTreatAsContinuingLoad { No, Yes };
+enum class ShouldTreatAsContinuingLoad : bool { No, Yes };
} // namespace WebCore
Modified: trunk/Source/WebCore/page/AutoplayEvent.h (237109 => 237110)
--- trunk/Source/WebCore/page/AutoplayEvent.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/page/AutoplayEvent.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -27,7 +27,7 @@
namespace WebCore {
-enum class AutoplayEvent {
+enum class AutoplayEvent : uint8_t {
DidPreventMediaFromPlaying,
DidPlayMediaPreventedFromPlaying,
DidAutoplayMediaPastThresholdWithoutUserInterference,
Modified: trunk/Source/WebCore/page/ChromeClient.h (237109 => 237110)
--- trunk/Source/WebCore/page/ChromeClient.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/page/ChromeClient.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -105,7 +105,7 @@
struct ViewportArguments;
struct WindowFeatures;
-enum class RouteSharingPolicy;
+enum class RouteSharingPolicy : uint8_t;
class WEBCORE_EXPORT ChromeClient {
public:
Modified: trunk/Source/WebCore/page/DiagnosticLoggingClient.h (237109 => 237110)
--- trunk/Source/WebCore/page/DiagnosticLoggingClient.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/page/DiagnosticLoggingClient.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -32,7 +32,7 @@
namespace WebCore {
-enum class ShouldSample { No, Yes };
+enum class ShouldSample : bool { No, Yes };
class DiagnosticLoggingClient {
WTF_MAKE_FAST_ALLOCATED;
Modified: trunk/Source/WebCore/page/Page.h (237109 => 237110)
--- trunk/Source/WebCore/page/Page.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/page/Page.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -162,8 +162,8 @@
enum class CanWrap : bool;
enum class DidWrap : bool;
-enum class RouteSharingPolicy;
-enum class ShouldTreatAsContinuingLoad;
+enum class RouteSharingPolicy : uint8_t;
+enum class ShouldTreatAsContinuingLoad : bool;
class Page : public Supplementable<Page> {
WTF_MAKE_NONCOPYABLE(Page);
Modified: trunk/Source/WebCore/platform/CookiesStrategy.h (237109 => 237110)
--- trunk/Source/WebCore/platform/CookiesStrategy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/platform/CookiesStrategy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -37,7 +37,7 @@
struct Cookie;
struct SameSiteInfo;
-enum class IncludeSecureCookies { No, Yes };
+enum class IncludeSecureCookies : bool { No, Yes };
class CookiesStrategy {
public:
Modified: trunk/Source/WebCore/platform/audio/AudioSession.h (237109 => 237110)
--- trunk/Source/WebCore/platform/audio/AudioSession.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/platform/audio/AudioSession.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -36,7 +36,7 @@
class AudioSessionPrivate;
-enum class RouteSharingPolicy {
+enum class RouteSharingPolicy : uint8_t {
Default,
LongForm,
Independent,
Modified: trunk/Source/WebCore/platform/network/NetworkStorageSession.h (237109 => 237110)
--- trunk/Source/WebCore/platform/network/NetworkStorageSession.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/platform/network/NetworkStorageSession.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -68,7 +68,7 @@
struct CookieRequestHeaderFieldProxy;
struct SameSiteInfo;
-enum class IncludeSecureCookies;
+enum class IncludeSecureCookies : bool;
class NetworkStorageSession {
WTF_MAKE_NONCOPYABLE(NetworkStorageSession); WTF_MAKE_FAST_ALLOCATED;
Modified: trunk/Source/WebCore/platform/network/StoredCredentialsPolicy.h (237109 => 237110)
--- trunk/Source/WebCore/platform/network/StoredCredentialsPolicy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/platform/network/StoredCredentialsPolicy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -27,8 +27,7 @@
namespace WebCore {
-// FIXME: should be : uint8_t but need to fix WebKit2 IPC codegen.
-enum class StoredCredentialsPolicy {
+enum class StoredCredentialsPolicy : uint8_t {
DoNotUse,
Use,
};
Modified: trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h (237109 => 237110)
--- trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -32,7 +32,7 @@
struct CookieRequestHeaderFieldProxy;
struct SameSiteInfo;
-enum class IncludeSecureCookies;
+enum class IncludeSecureCookies : bool;
class CookieJarCurl {
public:
Modified: trunk/Source/WebCore/workers/service/SWClientConnection.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/SWClientConnection.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/SWClientConnection.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -42,9 +42,9 @@
class ServiceWorkerContainer;
class ServiceWorkerRegistration;
class SharedBuffer;
-enum class ServiceWorkerRegistrationState;
-enum class ServiceWorkerState;
-enum class ShouldNotifyWhenResolved;
+enum class ServiceWorkerRegistrationState : uint8_t;
+enum class ServiceWorkerState : uint8_t;
+enum class ShouldNotifyWhenResolved : bool;
struct ExceptionData;
struct MessageWithMessagePorts;
struct ServiceWorkerClientData;
Modified: trunk/Source/WebCore/workers/service/ServiceWorker.cpp (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorker.cpp 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorker.cpp 2018-10-15 15:23:59 UTC (rev 237110)
@@ -64,7 +64,7 @@
relaxAdoptionRequirement();
updatePendingActivityForEventDispatch();
- WORKER_RELEASE_LOG_IF_ALLOWED("ServiceWorker: ID: %llu, state: %u", identifier().toUInt64(), m_data.state);
+ WORKER_RELEASE_LOG_IF_ALLOWED("ServiceWorker: ID: %llu, state: %hhu", identifier().toUInt64(), m_data.state);
}
ServiceWorker::~ServiceWorker()
@@ -82,7 +82,7 @@
context->postTask([this, protectedThis = makeRef(*this), state](ScriptExecutionContext&) {
ASSERT(this->state() != state);
- WORKER_RELEASE_LOG_IF_ALLOWED("scheduleTaskToUpdateState: Updating service worker %llu state from %u to %u. Registration ID: %llu", identifier().toUInt64(), m_data.state, state, registrationIdentifier().toUInt64());
+ WORKER_RELEASE_LOG_IF_ALLOWED("scheduleTaskToUpdateState: Updating service worker %llu state from %hhu to %hhu. Registration ID: %llu", identifier().toUInt64(), m_data.state, state, registrationIdentifier().toUInt64());
m_data.state = state;
if (state != State::Installing && !m_isStopped) {
ASSERT(m_pendingActivityForEventDispatch);
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -45,7 +45,7 @@
class NavigatorBase;
class ServiceWorker;
-enum class ServiceWorkerUpdateViaCache;
+enum class ServiceWorkerUpdateViaCache : uint8_t;
enum class WorkerType;
class ServiceWorkerContainer final : public EventTargetWithInlineData, public ActiveDOMObject, public ServiceWorkerJobClient {
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationData.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationData.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationData.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -36,7 +36,7 @@
namespace WebCore {
-enum class ServiceWorkerUpdateViaCache;
+enum class ServiceWorkerUpdateViaCache : uint8_t;
struct ServiceWorkerRegistrationData {
ServiceWorkerRegistrationKey key;
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -31,7 +31,7 @@
namespace WebCore {
-enum class ServiceWorkerUpdateViaCache;
+enum class ServiceWorkerUpdateViaCache : uint8_t;
enum class WorkerType;
struct ServiceWorkerRegistrationOptions {
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerTypes.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorkerTypes.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerTypes.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -38,13 +38,13 @@
struct ServiceWorkerClientData;
struct ServiceWorkerClientIdentifier;
-enum class ServiceWorkerRegistrationState {
+enum class ServiceWorkerRegistrationState : uint8_t {
Installing = 0,
Waiting = 1,
Active = 2,
};
-enum class ServiceWorkerState {
+enum class ServiceWorkerState : uint8_t {
Installing,
Installed,
Activating,
@@ -59,7 +59,7 @@
None
};
-enum class ShouldNotifyWhenResolved { No, Yes };
+enum class ShouldNotifyWhenResolved : bool { No, Yes };
enum ServiceWorkerRegistrationIdentifierType { };
using ServiceWorkerRegistrationIdentifier = ObjectIdentifier<ServiceWorkerRegistrationIdentifierType>;
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerUpdateViaCache.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/ServiceWorkerUpdateViaCache.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerUpdateViaCache.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -31,7 +31,7 @@
namespace WebCore {
-enum class ServiceWorkerUpdateViaCache {
+enum class ServiceWorkerUpdateViaCache : uint8_t {
Imports,
All,
None,
Modified: trunk/Source/WebCore/workers/service/server/SWServer.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/server/SWServer.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/server/SWServer.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -53,8 +53,8 @@
class SWServerJobQueue;
class SWServerRegistration;
class SWServerToContextConnection;
-enum class ServiceWorkerRegistrationState;
-enum class ServiceWorkerState;
+enum class ServiceWorkerRegistrationState : uint8_t;
+enum class ServiceWorkerState : uint8_t;
struct ExceptionData;
struct ServiceWorkerClientQueryOptions;
struct ServiceWorkerContextData;
Modified: trunk/Source/WebCore/workers/service/server/SWServerRegistration.h (237109 => 237110)
--- trunk/Source/WebCore/workers/service/server/SWServerRegistration.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebCore/workers/service/server/SWServerRegistration.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -39,8 +39,8 @@
class SWServer;
class SWServerWorker;
-enum class ServiceWorkerRegistrationState;
-enum class ServiceWorkerState;
+enum class ServiceWorkerRegistrationState : uint8_t;
+enum class ServiceWorkerState : uint8_t;
struct ExceptionData;
struct ServiceWorkerContextData;
struct ServiceWorkerFetchResult;
Modified: trunk/Source/WebKit/ChangeLog (237109 => 237110)
--- trunk/Source/WebKit/ChangeLog 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/ChangeLog 2018-10-15 15:23:59 UTC (rev 237110)
@@ -1,3 +1,43 @@
+2018-10-15 Alex Christensen <[email protected]>
+
+ Shrink more enum classes
+ https://bugs.webkit.org/show_bug.cgi?id=190540
+
+ Reviewed by Chris Dumez.
+
+ * NetworkProcess/NetworkConnectionToWebProcess.h:
+ * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
+ * NetworkProcess/NetworkDataTask.h:
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/NetworkProcess.messages.in:
+ * Shared/Authentication/AuthenticationChallengeDisposition.h:
+ * Shared/Authentication/AuthenticationManager.h:
+ * Shared/Authentication/AuthenticationManager.messages.in:
+ * Shared/DragControllerAction.h:
+ * Shared/LayerTreeContext.h:
+ * Shared/UndoOrRedo.h:
+ * UIProcess/Authentication/AuthenticationDecisionListener.h:
+ * UIProcess/Cocoa/WebViewImpl.h:
+ * UIProcess/Network/NetworkProcessProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.messages.in:
+ * UIProcess/Notifications/WebNotification.h:
+ * UIProcess/Notifications/WebNotificationManagerProxy.h:
+ * UIProcess/PageClient.h:
+ * UIProcess/UserContent/WebUserContentControllerProxy.h:
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/WebPageProxy.messages.in:
+ * UIProcess/ios/PageClientImplIOS.h:
+ * UIProcess/ios/WKContentViewInteraction.h:
+ * UIProcess/ios/forms/WKAirPlayRoutePicker.h:
+ * WebProcess/Automation/WebAutomationSessionProxy.messages.in:
+ * WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
+ * WebProcess/Storage/WebSWClientConnection.messages.in:
+ * WebProcess/UserContent/InjectUserScriptImmediately.h:
+ * WebProcess/UserContent/WebUserContentController.h:
+ * WebProcess/UserContent/WebUserContentController.messages.in:
+ * WebProcess/WebPage/WebPage.h:
+ * WebProcess/WebPage/WebPage.messages.in:
+
2018-10-15 Michael Catanzaro <[email protected]>
Add new files missing from previous commit.
Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h (237109 => 237110)
--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -48,7 +48,7 @@
class ResourceRequest;
struct SameSiteInfo;
-enum class IncludeSecureCookies;
+enum class IncludeSecureCookies : bool;
}
namespace WebKit {
Modified: trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in (237109 => 237110)
--- trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -34,10 +34,10 @@
StartDownload(PAL::SessionID sessionID, WebKit::DownloadID downloadID, WebCore::ResourceRequest request, String suggestedName)
ConvertMainResourceLoadToDownload(PAL::SessionID sessionID, uint64_t mainResourceLoadIdentifier, WebKit::DownloadID downloadID, WebCore::ResourceRequest request, WebCore::ResourceResponse response)
- CookiesForDOM(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, enum WebCore::IncludeSecureCookies includeSecureCookies) -> (String cookieString, bool didAccessSecureCookies)
+ CookiesForDOM(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, enum:bool WebCore::IncludeSecureCookies includeSecureCookies) -> (String cookieString, bool didAccessSecureCookies)
SetCookiesFromDOM(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, String cookieString)
CookiesEnabled(PAL::SessionID sessionID) -> (bool enabled)
- CookieRequestHeaderFieldValue(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, enum WebCore::IncludeSecureCookies includeSecureCookies) -> (String cookieString, bool didAccessSecureCookies)
+ CookieRequestHeaderFieldValue(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID, enum:bool WebCore::IncludeSecureCookies includeSecureCookies) -> (String cookieString, bool didAccessSecureCookies)
GetRawCookies(PAL::SessionID sessionID, WebCore::URL firstParty, struct WebCore::SameSiteInfo sameSiteInfo, WebCore::URL url, std::optional<uint64_t> frameID, std::optional<uint64_t> pageID) -> (Vector<WebCore::Cookie> cookies)
DeleteCookie(PAL::SessionID sessionID, WebCore::URL url, String cookieName)
Modified: trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h (237109 => 237110)
--- trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -50,7 +50,7 @@
class NetworkLoadParameters;
class NetworkSession;
class PendingDownload;
-enum class AuthenticationChallengeDisposition;
+enum class AuthenticationChallengeDisposition : uint8_t;
using RedirectCompletionHandler = CompletionHandler<void(WebCore::ResourceRequest&&)>;
using ChallengeCompletionHandler = CompletionHandler<void(AuthenticationChallengeDisposition, const WebCore::Credential&)>;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (237109 => 237110)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -66,7 +66,7 @@
class SWServer;
class SecurityOrigin;
class URL;
-enum class StoredCredentialsPolicy;
+enum class StoredCredentialsPolicy : uint8_t;
struct MessageWithMessagePorts;
struct SecurityOriginData;
struct SoupNetworkProxySettings;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in (237109 => 237110)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -79,7 +79,7 @@
WriteBlobToFilePath(WebCore::URL blobURL, String path, WebKit::SandboxExtension::Handle handle, uint64_t callbackID)
- PreconnectTo(WebCore::URL url, enum WebCore::StoredCredentialsPolicy storedCredentialsPolicy);
+ PreconnectTo(WebCore::URL url, enum:uint8_t WebCore::StoredCredentialsPolicy storedCredentialsPolicy);
#if ENABLE(RESOURCE_LOAD_STATISTICS)
UpdatePrevalentDomainsToBlockCookiesFor(PAL::SessionID sessionID, Vector<String> domainsToBlock, bool shouldClearFirst, uint64_t contextId)
Modified: trunk/Source/WebKit/Scripts/webkit/messages.py (237109 => 237110)
--- trunk/Source/WebKit/Scripts/webkit/messages.py 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Scripts/webkit/messages.py 2018-10-15 15:23:59 UTC (rev 237110)
@@ -86,7 +86,7 @@
if type in builtin_types:
return type
- if kind.startswith('enum'):
+ if kind.startswith('enum:'):
return type
return 'const %s&' % type
@@ -151,8 +151,8 @@
qualified_name = '%s::%s' % (namespace, type)
if kind == 'struct':
return 'struct %s' % type
- elif kind.startswith('enum'):
- return 'enum class %s %s' % (type, kind[4:])
+ elif kind.startswith('enum:'):
+ return 'enum class %s : %s' % (type, kind[5:])
else:
return 'class %s' % type
@@ -185,8 +185,6 @@
no_forward_declaration_types = frozenset([
'MachSendRight',
- 'MessageLevel',
- 'MessageSource',
'String',
'WebCore::DocumentIdentifier',
'WebCore::FetchIdentifier',
@@ -371,8 +369,8 @@
special_cases = {
'IPC::SharedBufferDataReference': ['"SharedBufferDataReference.h"', '"DataReference.h"'],
'MachSendRight': ['<wtf/MachSendRight.h>'],
- 'MessageLevel': ['<_javascript_Core/ConsoleTypes.h>'],
- 'MessageSource': ['<_javascript_Core/ConsoleTypes.h>'],
+ 'JSC::MessageLevel': ['<_javascript_Core/ConsoleTypes.h>'],
+ 'JSC::MessageSource': ['<_javascript_Core/ConsoleTypes.h>'],
'MonotonicTime': ['<wtf/MonotonicTime.h>'],
'Seconds': ['<wtf/Seconds.h>'],
'WallTime': ['<wtf/WallTime.h>'],
Modified: trunk/Source/WebKit/Scripts/webkit/parser.py (237109 => 237110)
--- trunk/Source/WebKit/Scripts/webkit/parser.py 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Scripts/webkit/parser.py 2018-10-15 15:23:59 UTC (rev 237110)
@@ -134,7 +134,7 @@
if split[0].startswith('struct '):
parameter_kind = 'struct'
split[0] = split[0][7:]
- elif split[0].startswith('enum'):
+ elif split[0].startswith('enum:'):
parameter_kind = split[0][:split[0].find(' ')]
split[0] = split[0][split[0].find(' ') + 1:]
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebKit {
-enum class AuthenticationChallengeDisposition {
+enum class AuthenticationChallengeDisposition : uint8_t {
UseCredential,
PerformDefaultHandling,
Cancel,
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -51,7 +51,7 @@
class DownloadID;
class WebFrame;
-enum class AuthenticationChallengeDisposition;
+enum class AuthenticationChallengeDisposition : uint8_t;
using ChallengeCompletionHandler = CompletionHandler<void(AuthenticationChallengeDisposition, const WebCore::Credential&)>;
class AuthenticationManager : public NetworkProcessSupplement, public IPC::MessageReceiver, public CanMakeWeakPtr<AuthenticationManager> {
Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in (237109 => 237110)
--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -21,5 +21,5 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
messages -> AuthenticationManager {
- void CompleteAuthenticationChallenge(uint64_t challengeID, enum WebKit::AuthenticationChallengeDisposition disposition, WebCore::Credential credential);
+ void CompleteAuthenticationChallenge(uint64_t challengeID, enum:uint8_t WebKit::AuthenticationChallengeDisposition disposition, WebCore::Credential credential);
}
Modified: trunk/Source/WebKit/Shared/CoordinateSystem.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/CoordinateSystem.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/CoordinateSystem.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebKit {
-enum class CoordinateSystem {
+enum class CoordinateSystem : uint8_t {
Page = 0,
LayoutViewport,
VisualViewport,
Modified: trunk/Source/WebKit/Shared/DragControllerAction.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/DragControllerAction.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/DragControllerAction.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -27,7 +27,7 @@
namespace WebKit {
-enum class DragControllerAction {
+enum class DragControllerAction : uint8_t {
Entered,
Updated,
Exited,
Modified: trunk/Source/WebKit/Shared/LayerTreeContext.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/LayerTreeContext.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/LayerTreeContext.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -35,7 +35,7 @@
namespace WebKit {
-enum class LayerHostingMode {
+enum class LayerHostingMode : uint8_t {
InProcess,
#if HAVE(OUT_OF_PROCESS_LAYER_HOSTING)
OutOfProcess
Modified: trunk/Source/WebKit/Shared/UndoOrRedo.h (237109 => 237110)
--- trunk/Source/WebKit/Shared/UndoOrRedo.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/Shared/UndoOrRedo.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebKit {
-enum class UndoOrRedo { Undo, Redo };
+enum class UndoOrRedo : bool { Undo, Redo };
}
Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -41,7 +41,7 @@
class DrawingAreaProxy;
class WebPageNamespace;
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class PageClientImpl : public PageClient
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Source/WebKit/UIProcess/API/wpe/PageClientImpl.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/API/wpe/PageClientImpl.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/API/wpe/PageClientImpl.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -38,7 +38,7 @@
class ScrollGestureController;
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class PageClientImpl final : public PageClient
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Source/WebKit/UIProcess/Authentication/AuthenticationDecisionListener.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Authentication/AuthenticationDecisionListener.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Authentication/AuthenticationDecisionListener.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -32,7 +32,7 @@
namespace WebKit {
-enum class AuthenticationChallengeDisposition;
+enum class AuthenticationChallengeDisposition : uint8_t;
class AuthenticationChallengeProxy;
class AuthenticationDecisionListener : public API::ObjectImpl<API::Object::Type::AuthenticationDecisionListener> {
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -142,7 +142,7 @@
class WebProcessPool;
struct ColorSpaceData;
struct WebHitTestResultData;
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
typedef id <NSValidatedUserInterfaceItem> ValidationItem;
typedef Vector<RetainPtr<ValidationItem>> ValidationVector;
Modified: trunk/Source/WebKit/UIProcess/DefaultUndoController.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/DefaultUndoController.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/DefaultUndoController.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -26,7 +26,7 @@
namespace WebKit {
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class DefaultUndoController {
public:
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef NetworkProcessProxy_h
-#define NetworkProcessProxy_h
+#pragma once
#include "APIWebsiteDataStore.h"
#include "ChildProcessProxy.h"
@@ -47,7 +46,7 @@
class AuthenticationChallenge;
class ProtectionSpace;
class ResourceRequest;
-enum class ShouldSample;
+enum class ShouldSample : bool;
class SecurityOrigin;
class URL;
struct SecurityOriginData;
@@ -205,5 +204,3 @@
};
} // namespace WebKit
-
-#endif // NetworkProcessProxy_h
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -37,9 +37,9 @@
SetIsHoldingLockedFiles(bool isHoldingLockedFiles)
# Diagnostic messages logging
- LogDiagnosticMessage(uint64_t pageID, String message, String description, enum WebCore::ShouldSample shouldSample)
- LogDiagnosticMessageWithResult(uint64_t pageID, String message, String description, uint32_t result, enum WebCore::ShouldSample shouldSample)
- LogDiagnosticMessageWithValue(uint64_t pageID, String message, String description, double value, unsigned significantFigures, enum WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessage(uint64_t pageID, String message, String description, enum:bool WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessageWithResult(uint64_t pageID, String message, String description, uint32_t result, enum:bool WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessageWithValue(uint64_t pageID, String message, String description, double value, unsigned significantFigures, enum:bool WebCore::ShouldSample shouldSample)
#if ENABLE(RESOURCE_LOAD_STATISTICS)
DidUpdateBlockCookies(uint64_t callbackId)
Modified: trunk/Source/WebKit/UIProcess/Notifications/WebNotification.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Notifications/WebNotification.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Notifications/WebNotification.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebNotification_h
-#define WebNotification_h
+#pragma once
#include "APIObject.h"
#include "APISecurityOrigin.h"
@@ -32,7 +31,7 @@
#include <wtf/text/WTFString.h>
namespace WebCore {
-enum class NotificationDirection;
+enum class NotificationDirection : uint8_t;
}
namespace WebKit {
@@ -75,5 +74,3 @@
}
} // namespace WebKit
-
-#endif // WebNotification_h
Modified: trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebNotificationManagerProxy_h
-#define WebNotificationManagerProxy_h
+#pragma once
#include "APIObject.h"
#include "MessageReceiver.h"
@@ -34,7 +33,7 @@
#include <wtf/text/StringHash.h>
namespace WebCore {
-enum class NotificationDirection;
+enum class NotificationDirection : uint8_t;
}
namespace API {
@@ -95,5 +94,3 @@
};
} // namespace WebKit
-
-#endif // WebNotificationManagerProxy_h
Modified: trunk/Source/WebKit/UIProcess/PageClient.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/PageClient.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/PageClient.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -73,7 +73,7 @@
class TextIndicator;
class WebMediaSessionManager;
-enum class RouteSharingPolicy;
+enum class RouteSharingPolicy : uint8_t;
enum class ScrollbarStyle;
enum class TextIndicatorWindowLifetime : uint8_t;
enum class TextIndicatorWindowDismissalAnimation : uint8_t;
@@ -96,7 +96,7 @@
namespace WebKit {
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class ContextMenuContextData;
class DownloadProxy;
Modified: trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -59,7 +59,7 @@
class WebScriptMessageHandler;
struct FrameInfoData;
struct WebPageCreationParameters;
-enum class InjectUserScriptImmediately;
+enum class InjectUserScriptImmediately : bool;
class WebUserContentControllerProxy : public API::ObjectImpl<API::Object::Type::UserContentController>, private IPC::MessageReceiver {
public:
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -176,11 +176,11 @@
enum SelectionDirection : uint8_t;
-enum class AutoplayEvent;
+enum class AutoplayEvent : uint8_t;
enum class HasInsecureContent : uint8_t;
-enum class NotificationDirection;
-enum class ShouldSample;
-enum class ShouldTreatAsContinuingLoad;
+enum class NotificationDirection : uint8_t;
+enum class ShouldSample : bool;
+enum class ShouldTreatAsContinuingLoad : bool;
struct ApplicationManifest;
struct BackForwardItemIdentifier;
@@ -266,7 +266,7 @@
struct URLSchemeTaskParameters;
enum class ProcessSwapRequestedByClient;
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
#if USE(QUICK_LOOK)
class QuickLookDocumentData;
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -107,8 +107,8 @@
# Policy messages
DecidePolicyForResponse(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, WebCore::ResourceResponse response, WebCore::ResourceRequest request, bool canShowMIMEType, uint64_t listenerID, WebKit::UserData userData)
- DecidePolicyForNavigationActionAsync(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, WebCore::ResourceResponse redirectResponse, WebKit::UserData userData, enum WebCore::ShouldSkipSafeBrowsingCheck shouldSkipSafeBrowsingCheck, uint64_t listenerID)
- DecidePolicyForNavigationActionSync(uint64_t frameID, bool isMainFrame, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, WebCore::ResourceResponse redirectResponse, WebKit::UserData userData, enum WebCore::ShouldSkipSafeBrowsingCheck shouldSkipSafeBrowsingCheck) -> (enum:uint8_t WebCore::PolicyAction policyAction, uint64_t newNavigationID, WebKit::DownloadID downloadID, std::optional<WebKit::WebsitePoliciesData> websitePolicies) Delayed
+ DecidePolicyForNavigationActionAsync(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, WebCore::ResourceResponse redirectResponse, WebKit::UserData userData, enum:bool WebCore::ShouldSkipSafeBrowsingCheck shouldSkipSafeBrowsingCheck, uint64_t listenerID)
+ DecidePolicyForNavigationActionSync(uint64_t frameID, bool isMainFrame, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, WebCore::ResourceResponse redirectResponse, WebKit::UserData userData, enum:bool WebCore::ShouldSkipSafeBrowsingCheck shouldSkipSafeBrowsingCheck) -> (enum:uint8_t WebCore::PolicyAction policyAction, uint64_t newNavigationID, WebKit::DownloadID downloadID, std::optional<WebKit::WebsitePoliciesData> websitePolicies) Delayed
DecidePolicyForNewWindowAction(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, struct WebKit::NavigationActionData navigationActionData, WebCore::ResourceRequest request, String frameName, uint64_t listenerID, WebKit::UserData userData)
UnableToImplementPolicy(uint64_t frameID, WebCore::ResourceError error, WebKit::UserData userData)
@@ -196,7 +196,7 @@
InterpretKeyEvent(struct WebKit::EditorState state, bool isCharEvent) -> (bool handled)
DidReceivePositionInformation(struct WebKit::InteractionInformationAtPosition information)
SaveImageToLibrary(WebKit::SharedMemory::Handle handle, uint64_t size)
- ShowPlaybackTargetPicker(bool hasVideo, WebCore::IntRect elementRect, enum WebCore::RouteSharingPolicy policy, String routingContextUID)
+ ShowPlaybackTargetPicker(bool hasVideo, WebCore::IntRect elementRect, enum:uint8_t WebCore::RouteSharingPolicy policy, String routingContextUID)
CommitPotentialTapFailed()
DidNotHandleTapAsClick(WebCore::IntPoint point)
DidCompleteSyntheticClick()
@@ -239,14 +239,14 @@
RegisterEditCommandForUndo(uint64_t commandID, uint32_t editAction)
ClearAllEditCommands()
RegisterInsertionUndoGrouping()
- CanUndoRedo(enum WebKit::UndoOrRedo undoOrRedo) -> (bool result)
- ExecuteUndoRedo(enum WebKit::UndoOrRedo undoOrRedo) -> ()
+ CanUndoRedo(enum:bool WebKit::UndoOrRedo undoOrRedo) -> (bool result)
+ ExecuteUndoRedo(enum:bool WebKit::UndoOrRedo undoOrRedo) -> ()
# Diagnostic messages logging
- LogDiagnosticMessage(String message, String description, enum WebCore::ShouldSample shouldSample)
- LogDiagnosticMessageWithResult(String message, String description, uint32_t result, enum WebCore::ShouldSample shouldSample)
- LogDiagnosticMessageWithValue(String message, String description, double value, unsigned significantFigures, enum WebCore::ShouldSample shouldSample)
- LogDiagnosticMessageWithEnhancedPrivacy(String message, String description, enum WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessage(String message, String description, enum:bool WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessageWithResult(String message, String description, uint32_t result, enum:bool WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessageWithValue(String message, String description, double value, unsigned significantFigures, enum:bool WebCore::ShouldSample shouldSample)
+ LogDiagnosticMessageWithEnhancedPrivacy(String message, String description, enum:bool WebCore::ShouldSample shouldSample)
# Performance logging
LogScrollingEvent(uint32_t eventType, MonotonicTime timestamp, uint64_t data)
@@ -293,7 +293,7 @@
# Notification messages
RequestNotificationPermission(uint64_t requestID, String originIdentifier)
- ShowNotification(String title, String body, String iconURL, String tag, String lang, enum WebCore::NotificationDirection dir, String originIdentifier, uint64_t notificationID)
+ ShowNotification(String title, String body, String iconURL, String tag, String lang, enum:uint8_t WebCore::NotificationDirection dir, String originIdentifier, uint64_t notificationID)
CancelNotification(uint64_t notificationID)
ClearNotifications(Vector<uint64_t> notificationIDs)
DidDestroyNotification(uint64_t notificationID)
@@ -469,7 +469,7 @@
#endif
IsPlayingMediaDidChange(unsigned state, uint64_t sourceElementID)
- HandleAutoplayEvent(enum WebCore::AutoplayEvent event, OptionSet<WebCore::AutoplayEventFlags> flags)
+ HandleAutoplayEvent(enum:uint8_t WebCore::AutoplayEvent event, OptionSet<WebCore::AutoplayEventFlags> flags)
#if ENABLE(MEDIA_SESSION)
HasMediaSessionWithActiveMediaElementsDidChange(bool state)
Modified: trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -40,7 +40,7 @@
namespace WebKit {
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class PageClientImpl : public PageClientImplCocoa
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -69,7 +69,7 @@
class SelectionRect;
struct PromisedAttachmentInfo;
struct ShareDataWithParsedURL;
-enum class RouteSharingPolicy;
+enum class RouteSharingPolicy : uint8_t;
}
#if ENABLE(DRAG_SUPPORT)
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -30,7 +30,7 @@
#import <Foundation/Foundation.h>
namespace WebCore {
-enum class RouteSharingPolicy;
+enum class RouteSharingPolicy : uint8_t;
}
@class UIView;
Modified: trunk/Source/WebKit/UIProcess/win/PageClientImpl.h (237109 => 237110)
--- trunk/Source/WebKit/UIProcess/win/PageClientImpl.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/UIProcess/win/PageClientImpl.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -40,7 +40,7 @@
class WebPageNamespace;
class WebView;
-enum class UndoOrRedo;
+enum class UndoOrRedo : bool;
class PageClientImpl : public PageClient
#if ENABLE(FULLSCREEN_API)
Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -30,7 +30,7 @@
FocusFrame(uint64_t pageID, uint64_t frameID)
-ComputeElementLayout(uint64_t pageID, uint64_t frameID, String nodeHandle, bool scrollIntoViewIfNeeded, enum WebKit::CoordinateSystem coordinateSystem, uint64_t callbackID)
+ ComputeElementLayout(uint64_t pageID, uint64_t frameID, String nodeHandle, bool scrollIntoViewIfNeeded, enum:uint8_t WebKit::CoordinateSystem coordinateSystem, uint64_t callbackID)
SelectOptionElement(uint64_t pageID, uint64_t frameID, String nodeHandle, uint64_t callbackID)
Modified: trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -17,8 +17,7 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#ifndef UserMediaPermissionRequestManager_h
-#define UserMediaPermissionRequestManager_h
+#pragma once
#if ENABLE(MEDIA_STREAM)
@@ -38,7 +37,7 @@
class WebPage;
-enum class DeviceAccessState { NoAccess, SessionAccess, PersistentAccess };
+enum class DeviceAccessState : uint8_t { NoAccess, SessionAccess, PersistentAccess };
class UserMediaPermissionRequestManager : public CanMakeWeakPtr<UserMediaPermissionRequestManager>, private WebCore::MediaCanStartListener, private WebCore::ActivityStateChangeObserver {
public:
@@ -107,5 +106,3 @@
} // namespace WTF
#endif // ENABLE(MEDIA_STREAM)
-
-#endif // UserMediaPermissionRequestManager_h
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -25,14 +25,14 @@
messages -> WebSWClientConnection {
# When possible, these messages can be implemented directly by WebCore::SWServer::Connection
JobRejectedInServer(WebCore::ServiceWorkerJobIdentifier jobDataIdentifier, struct WebCore::ExceptionData exception)
- RegistrationJobResolvedInServer(WebCore::ServiceWorkerJobIdentifier jobDataIdentifier, struct WebCore::ServiceWorkerRegistrationData registration, enum WebCore::ShouldNotifyWhenResolved shouldNotifyWhenResolved)
+ RegistrationJobResolvedInServer(WebCore::ServiceWorkerJobIdentifier jobDataIdentifier, struct WebCore::ServiceWorkerRegistrationData registration, enum:bool WebCore::ShouldNotifyWhenResolved shouldNotifyWhenResolved)
UnregistrationJobResolvedInServer(WebCore::ServiceWorkerJobIdentifier jobDataIdentifier, bool unregistrationResult)
StartScriptFetchForServer(WebCore::ServiceWorkerJobIdentifier jobDataIdentifier, WebCore::ServiceWorkerRegistrationKey registrationKey, WebCore::FetchOptions::Cache cachePolicy)
- UpdateRegistrationState(WebCore::ServiceWorkerRegistrationIdentifier identifier, enum WebCore::ServiceWorkerRegistrationState state, std::optional<WebCore::ServiceWorkerData> serviceWorkerIdentifier)
- UpdateWorkerState(WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, enum WebCore::ServiceWorkerState state)
+ UpdateRegistrationState(WebCore::ServiceWorkerRegistrationIdentifier identifier, enum:uint8_t WebCore::ServiceWorkerRegistrationState state, std::optional<WebCore::ServiceWorkerData> serviceWorkerIdentifier)
+ UpdateWorkerState(WebCore::ServiceWorkerIdentifier serviceWorkerIdentifier, enum:uint8_t WebCore::ServiceWorkerState state)
FireUpdateFoundEvent(WebCore::ServiceWorkerRegistrationIdentifier identifier)
SetRegistrationLastUpdateTime(WebCore::ServiceWorkerRegistrationIdentifier identifier, WallTime lastUpdateTime)
- SetRegistrationUpdateViaCache(WebCore::ServiceWorkerRegistrationIdentifier identifier, enum WebCore::ServiceWorkerUpdateViaCache updateViaCache);
+ SetRegistrationUpdateViaCache(WebCore::ServiceWorkerRegistrationIdentifier identifier, enum:uint8_t WebCore::ServiceWorkerUpdateViaCache updateViaCache);
NotifyClientsOfControllerChange(HashSet<WebCore::DocumentIdentifier> contextIdentifiers, struct WebCore::ServiceWorkerData newController)
SetSWOriginTableIsImported()
Modified: trunk/Source/WebKit/WebProcess/UserContent/InjectUserScriptImmediately.h (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/UserContent/InjectUserScriptImmediately.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/UserContent/InjectUserScriptImmediately.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -29,7 +29,7 @@
namespace WebKit {
-enum class InjectUserScriptImmediately { No, Yes };
+enum class InjectUserScriptImmediately : bool { No, Yes };
}
Modified: trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.h (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -47,7 +47,7 @@
class InjectedBundleScriptWorld;
class WebCompiledContentRuleListData;
class WebUserMessageHandlerDescriptorProxy;
-enum class InjectUserScriptImmediately;
+enum class InjectUserScriptImmediately : bool;
class WebUserContentController final : public WebCore::UserContentProvider, private IPC::MessageReceiver {
public:
Modified: trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.messages.in (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/UserContent/WebUserContentController.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -27,7 +27,7 @@
AddUserContentWorlds(Vector<std::pair<uint64_t, String>> worlds);
RemoveUserContentWorlds(Vector<uint64_t> worldIdentifiers);
- AddUserScripts(Vector<struct WebKit::WebUserScriptData> userScripts, enum WebKit::InjectUserScriptImmediately immediately);
+ AddUserScripts(Vector<struct WebKit::WebUserScriptData> userScripts, enum:bool WebKit::InjectUserScriptImmediately immediately);
RemoveUserScript(uint64_t worldIdentifier, uint64_t identifier);
RemoveAllUserScripts(Vector<uint64_t> worldIdentifiers);
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-10-15 15:23:59 UTC (rev 237110)
@@ -163,7 +163,7 @@
class VisiblePosition;
enum SyntheticClickType : int8_t;
-enum class ShouldTreatAsContinuingLoad;
+enum class ShouldTreatAsContinuingLoad : bool;
enum class TextIndicatorPresentationTransition : uint8_t;
struct BackForwardItemIdentifier;
@@ -229,9 +229,9 @@
class WebTouchEvent;
class RemoteLayerTreeTransaction;
-enum class DeviceAccessState;
+enum class DeviceAccessState : uint8_t;
enum FindOptions : uint16_t;
-enum class DragControllerAction;
+enum class DragControllerAction : uint8_t;
struct AssistedNodeInformation;
struct AttributedString;
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (237109 => 237110)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-10-15 15:10:27 UTC (rev 237109)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-10-15 15:23:59 UTC (rev 237110)
@@ -23,11 +23,11 @@
messages -> WebPage LegacyReceiver {
SetInitialFocus(bool forward, bool isKeyboardEventValid, WebKit::WebKeyboardEvent event, WebKit::CallbackID callbackID)
SetActivityState(OptionSet<WebCore::ActivityState::Flag> activityState, WebKit::ActivityStateChangeID activityStateChangeID, Vector<WebKit::CallbackID> callbackIDs)
- SetLayerHostingMode(enum WebKit::LayerHostingMode layerHostingMode)
+ SetLayerHostingMode(enum:uint8_t WebKit::LayerHostingMode layerHostingMode)
SetDrawsBackground(bool drawsBackground)
- AddConsoleMessage(uint64_t frameID, enum MessageSource messageSource, enum MessageLevel messageLevel, String message, uint64_t requestID)
+ AddConsoleMessage(uint64_t frameID, enum:uint8_t JSC::MessageSource messageSource, enum:uint8_t JSC::MessageLevel messageLevel, String message, uint64_t requestID)
SendCSPViolationReport(uint64_t frameID, WebCore::URL reportURL, IPC::FormDataReference reportData)
EnqueueSecurityPolicyViolationEvent(uint64_t frameID, WebCore::SecurityPolicyViolationEvent::Init eventInit)
@@ -140,7 +140,7 @@
ScrollBy(uint32_t scrollDirection, uint32_t scrollGranularity)
CenterSelectionInVisibleArea()
- GoToBackForwardItem(uint64_t navigationID, struct WebCore::BackForwardItemIdentifier backForwardItemID, enum:uint8_t WebCore::FrameLoadType backForwardType, enum WebCore::ShouldTreatAsContinuingLoad shouldTreatAsContinuingLoad)
+ GoToBackForwardItem(uint64_t navigationID, struct WebCore::BackForwardItemIdentifier backForwardItemID, enum:uint8_t WebCore::FrameLoadType backForwardType, enum:bool WebCore::ShouldTreatAsContinuingLoad shouldTreatAsContinuingLoad)
TryRestoreScrollPosition()
LoadURLInFrame(WebCore::URL url, uint64_t frameID)
@@ -262,10 +262,10 @@
# Drag and drop.
#if PLATFORM(GTK) && ENABLE(DRAG_SUPPORT)
- PerformDragControllerAction(enum WebKit::DragControllerAction action, WebCore::IntPoint clientPosition, WebCore::IntPoint globalPosition, uint64_t draggingSourceOperationMask, struct WebKit::WebSelectionData selection, uint32_t flags)
+ PerformDragControllerAction(enum:uint8_t WebKit::DragControllerAction action, WebCore::IntPoint clientPosition, WebCore::IntPoint globalPosition, uint64_t draggingSourceOperationMask, struct WebKit::WebSelectionData selection, uint32_t flags)
#endif
#if !PLATFORM(GTK) && ENABLE(DRAG_SUPPORT)
- PerformDragControllerAction(enum WebKit::DragControllerAction action, WebCore::DragData dragData, WebKit::SandboxExtension::Handle sandboxExtensionHandle, WebKit::SandboxExtension::HandleArray sandboxExtensionsForUpload)
+ PerformDragControllerAction(enum:uint8_t WebKit::DragControllerAction action, WebCore::DragData dragData, WebKit::SandboxExtension::Handle sandboxExtensionHandle, WebKit::SandboxExtension::HandleArray sandboxExtensionsForUpload)
#endif
#if ENABLE(DRAG_SUPPORT)
DidStartDrag()
@@ -325,7 +325,7 @@
UserMediaAccessWasGranted(uint64_t userMediaID, WebCore::CaptureDevice audioDevice, WebCore::CaptureDevice videoDevice, String mediaDeviceIdentifierHashSalt)
UserMediaAccessWasDenied(uint64_t userMediaID, uint64_t reason, String invalidConstraint)
DidCompleteMediaDeviceEnumeration(uint64_t userMediaID, Vector<WebCore::CaptureDevice> devices, String mediaDeviceIdentifierHashSalt, bool hasPersistentAccess)
- CaptureDevicesChanged(enum WebKit::DeviceAccessState accessState)
+ CaptureDevicesChanged(enum:uint8_t WebKit::DeviceAccessState accessState)
#if ENABLE(SANDBOX_EXTENSIONS)
GrantUserMediaDeviceSandboxExtensions(WebKit::MediaDeviceSandboxExtensions sandboxExtensions)
RevokeUserMediaDeviceSandboxExtensions(Vector<String> sandboxExtensionIDs)
