Title: [237111] trunk/Source/WebKit
- Revision
- 237111
- Author
- [email protected]
- Date
- 2018-10-15 08:29:47 -0700 (Mon, 15 Oct 2018)
Log Message
Fix assertion after r237102
https://bugs.webkit.org/show_bug.cgi?id=190459
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
Shipping Safari still uses shouldGoToBackForwardListItem, so only assert on
newer platforms like we do in WKPageSetPageLoaderClient.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237110 => 237111)
--- trunk/Source/WebKit/ChangeLog 2018-10-15 15:23:59 UTC (rev 237110)
+++ trunk/Source/WebKit/ChangeLog 2018-10-15 15:29:47 UTC (rev 237111)
@@ -1,5 +1,15 @@
2018-10-15 Alex Christensen <[email protected]>
+ Fix assertion after r237102
+ https://bugs.webkit.org/show_bug.cgi?id=190459
+
+ * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
+ (WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
+ Shipping Safari still uses shouldGoToBackForwardListItem, so only assert on
+ newer platforms like we do in WKPageSetPageLoaderClient.
+
+2018-10-15 Alex Christensen <[email protected]>
+
Shrink more enum classes
https://bugs.webkit.org/show_bug.cgi?id=190540
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp (237110 => 237111)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp 2018-10-15 15:23:59 UTC (rev 237110)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp 2018-10-15 15:29:47 UTC (rev 237111)
@@ -48,7 +48,10 @@
InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient(const WKBundlePageLoaderClientBase* client)
{
initialize(client);
+#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED > 101400
+ // Deprecated callbacks.
ASSERT(!m_client.shouldGoToBackForwardListItem);
+#endif
}
void InjectedBundlePageLoaderClient::willLoadURLRequest(WebPage& page, const ResourceRequest& request, API::Object* userData)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
