Title: [237383] trunk/Tools
- Revision
- 237383
- Author
- [email protected]
- Date
- 2018-10-24 07:32:43 -0700 (Wed, 24 Oct 2018)
Log Message
[GTK] TestSSL failing because of missing libsoup patch
https://bugs.webkit.org/show_bug.cgi?id=190869
Reviewed by Michael Catanzaro.
* gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
* gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/ChangeLog (237382 => 237383)
--- trunk/Tools/ChangeLog 2018-10-24 14:27:13 UTC (rev 237382)
+++ trunk/Tools/ChangeLog 2018-10-24 14:32:43 UTC (rev 237383)
@@ -1,3 +1,13 @@
+2018-10-24 Claudio Saavedra <[email protected]>
+
+ [GTK] TestSSL failing because of missing libsoup patch
+ https://bugs.webkit.org/show_bug.cgi?id=190869
+
+ Reviewed by Michael Catanzaro.
+
+ * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
+ * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
+
2018-10-23 Justin Fan <[email protected]>
[WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
Modified: trunk/Tools/gtk/jhbuild.modules (237382 => 237383)
--- trunk/Tools/gtk/jhbuild.modules 2018-10-24 14:27:13 UTC (rev 237382)
+++ trunk/Tools/gtk/jhbuild.modules 2018-10-24 14:32:43 UTC (rev 237383)
@@ -252,6 +252,7 @@
<patch file="libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch" strip="1"/>
<patch file="libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch" strip="1"/>
<patch file="libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch" strip="1"/>
+ <patch file="libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch" strip="1"/>
</branch>
</autotools>
Added: trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (0 => 237383)
--- trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch (rev 0)
+++ trunk/Tools/gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch 2018-10-24 14:32:43 UTC (rev 237383)
@@ -0,0 +1,29 @@
+From e8995d4e1d5cf984cf10327c59808976425b2f9c Mon Sep 17 00:00:00 2001
+From: Carlos Garcia Campos <[email protected]>
+Date: Fri, 20 Apr 2018 12:14:55 +0200
+Subject: [PATCH] soup-socket: fix critical warning when the peer-certificate
+ changes after disconnect
+
+(process:15586): GLib-GIO-CRITICAL **: 12:14:39.627: g_tls_connection_get_peer_certificate_errors: assertion 'G_IS_TLS_CONNECTION (conn)' failed
+
+We should disconnect the signal on disconnect_internal before clearing
+the connection object.
+---
+ libsoup/soup-socket.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
+index 5363dc72..311c627c 100644
+--- a/libsoup/soup-socket.c
++++ b/libsoup/soup-socket.c
+@@ -188,6 +188,7 @@ disconnect_internal (SoupSocket *sock, gboolean close)
+ g_clear_object (&priv->gsock);
+ if (priv->conn && close) {
+ g_io_stream_close (priv->conn, NULL, NULL);
++ g_signal_handlers_disconnect_by_data (priv->conn, sock);
+ g_clear_object (&priv->conn);
+ }
+
+--
+2.19.1
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
