Title: [237384] trunk/Source/WebKit
- Revision
- 237384
- Author
- [email protected]
- Date
- 2018-10-24 08:38:26 -0700 (Wed, 24 Oct 2018)
Log Message
REGRESSION (r237257): [iOS] Crashes in com.apple.WebKit: WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit
https://bugs.webkit.org/show_bug.cgi?id=190804
Reviewed by Alex Christensen.
Fix null-dereference of the drawing area in RemoteScrollingCoordinator::scheduleTreeStateCommit.
With process-swap-on-navigation enabled, suspended pages' drawing area gets torn down.
* WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237383 => 237384)
--- trunk/Source/WebKit/ChangeLog 2018-10-24 14:32:43 UTC (rev 237383)
+++ trunk/Source/WebKit/ChangeLog 2018-10-24 15:38:26 UTC (rev 237384)
@@ -1,3 +1,16 @@
+2018-10-24 Chris Dumez <[email protected]>
+
+ REGRESSION (r237257): [iOS] Crashes in com.apple.WebKit: WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit
+ https://bugs.webkit.org/show_bug.cgi?id=190804
+
+ Reviewed by Alex Christensen.
+
+ Fix null-dereference of the drawing area in RemoteScrollingCoordinator::scheduleTreeStateCommit.
+ With process-swap-on-navigation enabled, suspended pages' drawing area gets torn down.
+
+ * WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
+ (WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
+
2018-10-24 Claudio Saavedra <[email protected]>
[WPE][GTK] Cleanups to the certificate decoder
Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm (237383 => 237384)
--- trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm 2018-10-24 14:32:43 UTC (rev 237383)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm 2018-10-24 15:38:26 UTC (rev 237384)
@@ -61,7 +61,8 @@
void RemoteScrollingCoordinator::scheduleTreeStateCommit()
{
- m_webPage->drawingArea()->scheduleCompositingLayerFlush();
+ if (auto* drawingArea = m_webPage->drawingArea())
+ drawingArea->scheduleCompositingLayerFlush();
}
bool RemoteScrollingCoordinator::coordinatesScrollingForFrameView(const FrameView& frameView) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
