Title: [237795] trunk/Tools
- Revision
- 237795
- Author
- [email protected]
- Date
- 2018-11-05 02:46:38 -0800 (Mon, 05 Nov 2018)
Log Message
REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191225
Reviewed by Alejandro G. Castro.
Fix a memory leak causing this test to fail.
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::initializeWebView):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (237794 => 237795)
--- trunk/Tools/ChangeLog 2018-11-05 10:00:19 UTC (rev 237794)
+++ trunk/Tools/ChangeLog 2018-11-05 10:46:38 UTC (rev 237795)
@@ -1,3 +1,15 @@
+2018-11-05 Michael Catanzaro <[email protected]>
+
+ REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
+ https://bugs.webkit.org/show_bug.cgi?id=191225
+
+ Reviewed by Alejandro G. Castro.
+
+ Fix a memory leak causing this test to fail.
+
+ * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
+ (WebViewTest::initializeWebView):
+
2018-11-04 Zan Dobersek <[email protected]>
[webkitpy] Support WPE in the run-web-platform-tests script
Modified: trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp (237794 => 237795)
--- trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp 2018-11-05 10:00:19 UTC (rev 237794)
+++ trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp 2018-11-05 10:46:38 UTC (rev 237795)
@@ -49,14 +49,14 @@
{
g_assert(!m_webView);
- WebKitSettings* webkitSettings = webkit_settings_new();
- webkit_settings_set_enable_media_stream(webkitSettings, TRUE);
+ GRefPtr<WebKitSettings> settings = adoptGRef(webkit_settings_new());
+ webkit_settings_set_enable_media_stream(settings.get(), TRUE);
m_webView = WEBKIT_WEB_VIEW(g_object_new(WEBKIT_TYPE_WEB_VIEW,
#if PLATFORM(WPE)
"backend", Test::createWebViewBackend(),
#endif
- "settings", webkitSettings,
+ "settings", settings.get(),
"web-context", m_webContext.get(),
"user-content-manager", m_userContentManager.get(),
nullptr));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
