Title: [237796] trunk/Tools
Revision
237796
Author
[email protected]
Date
2018-11-05 04:19:47 -0800 (Mon, 05 Nov 2018)

Log Message

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (237795 => 237796)


--- trunk/Tools/ChangeLog	2018-11-05 10:46:38 UTC (rev 237795)
+++ trunk/Tools/ChangeLog	2018-11-05 12:19:47 UTC (rev 237796)
@@ -1,5 +1,18 @@
 2018-11-05  Michael Catanzaro  <[email protected]>
 
+        [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
+        https://bugs.webkit.org/show_bug.cgi?id=191221
+
+        Reviewed by Carlos Garcia Campos.
+
+        This test ensures that MSE is disabled by default, but we now enable it by default, so
+        reverse the semantics of the test.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings):
+
+2018-11-05  Michael Catanzaro  <[email protected]>
+
         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
         https://bugs.webkit.org/show_bug.cgi?id=191225
 

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (237795 => 237796)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2018-11-05 10:46:38 UTC (rev 237795)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2018-11-05 12:19:47 UTC (rev 237796)
@@ -314,10 +314,10 @@
     webkit_settings_set_enable_spatial_navigation(settings, TRUE);
     g_assert(webkit_settings_get_enable_spatial_navigation(settings));
 
-    // MediaSource is disabled by default
-    g_assert(!webkit_settings_get_enable_mediasource(settings));
-    webkit_settings_set_enable_mediasource(settings, TRUE);
+    // MediaSource is enabled by default
     g_assert(webkit_settings_get_enable_mediasource(settings));
+    webkit_settings_set_enable_mediasource(settings, FALSE);
+    g_assert(webkit_settings_get_enable_mediasource(settings));
 
     // EncryptedMedia is disabled by default
     g_assert(!webkit_settings_get_enable_encrypted_media(settings));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to