Title: [237797] trunk/Source/WebCore
- Revision
- 237797
- Author
- [email protected]
- Date
- 2018-11-05 05:55:21 -0800 (Mon, 05 Nov 2018)
Log Message
Remove some virtual methods in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=191251
Patch by Rob Buis <[email protected]> on 2018-11-05
Reviewed by Frédéric Wang.
Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.
No new tests since no change in functionality.
* loader/cache/CachedRawResource.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (237796 => 237797)
--- trunk/Source/WebCore/ChangeLog 2018-11-05 12:19:47 UTC (rev 237796)
+++ trunk/Source/WebCore/ChangeLog 2018-11-05 13:55:21 UTC (rev 237797)
@@ -1,3 +1,18 @@
+2018-11-05 Rob Buis <[email protected]>
+
+ Remove some virtual methods in CachedRawResource
+ https://bugs.webkit.org/show_bug.cgi?id=191251
+
+ Reviewed by Frédéric Wang.
+
+ Since CachedRawResource is final no need to introduce new virtual
+ methods in CachedRawResource. This patch also removes an outdated
+ comment and forward declaration.
+
+ No new tests since no change in functionality.
+
+ * loader/cache/CachedRawResource.h:
+
2018-11-05 Philippe Normand <[email protected]>
[GStreamer] Move elements registration to GStreamerCommon
Modified: trunk/Source/WebCore/loader/cache/CachedRawResource.h (237796 => 237797)
--- trunk/Source/WebCore/loader/cache/CachedRawResource.h 2018-11-05 12:19:47 UTC (rev 237796)
+++ trunk/Source/WebCore/loader/cache/CachedRawResource.h 2018-11-05 13:55:21 UTC (rev 237797)
@@ -29,18 +29,14 @@
class CachedResourceClient;
class ResourceTiming;
class SharedBufferDataView;
-class SubresourceLoader;
class CachedRawResource final : public CachedResource {
public:
CachedRawResource(CachedResourceRequest&&, Type, PAL::SessionID);
- // FIXME: AssociatedURLLoader shouldn't be a DocumentThreadableLoader and therefore shouldn't
- // use CachedRawResource. However, it is, and it needs to be able to defer loading.
- // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader.
- virtual void setDefersLoading(bool);
+ void setDefersLoading(bool);
- virtual void setDataBufferingPolicy(DataBufferingPolicy);
+ void setDataBufferingPolicy(DataBufferingPolicy);
// FIXME: This is exposed for the InspectorInstrumentation for preflights in DocumentThreadableLoader. It's also really lame.
unsigned long identifier() const { return m_identifier; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
