Title: [238500] trunk/Source/WebInspectorUI
- Revision
- 238500
- Author
- [email protected]
- Date
- 2018-11-26 10:20:55 -0800 (Mon, 26 Nov 2018)
Log Message
Web Inspector: Audit: automatically add to tab bar when the experimental setting is enabled
https://bugs.webkit.org/show_bug.cgi?id=191659
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
* UserInterface/Base/Main.js:
(WI.loaded):
Drive-by: use existing constants instead of hard-coded strings for consistency.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238499 => 238500)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-26 18:15:18 UTC (rev 238499)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-26 18:20:55 UTC (rev 238500)
@@ -1,3 +1,17 @@
+2018-11-26 Devin Rousso <[email protected]>
+
+ Web Inspector: Audit: automatically add to tab bar when the experimental setting is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=191659
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+ * UserInterface/Base/Main.js:
+ (WI.loaded):
+ Drive-by: use existing constants instead of hard-coded strings for consistency.
+
2018-11-25 Devin Rousso <[email protected]>
Web Inspector: Timelines: add Media timeline
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (238499 => 238500)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-26 18:15:18 UTC (rev 238499)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-26 18:20:55 UTC (rev 238500)
@@ -138,7 +138,16 @@
// Create settings.
this._showingSplitConsoleSetting = new WI.Setting("showing-split-console", false);
- this._openTabsSetting = new WI.Setting("open-tab-types", ["elements", "network", "debugger", "resources", "timeline", "storage", "canvas", "console"]);
+ this._openTabsSetting = new WI.Setting("open-tab-types", [
+ WI.ElementsTabContentView.Type,
+ WI.NetworkTabContentView.Type,
+ WI.DebuggerTabContentView.Type,
+ WI.ResourcesTabContentView.Type,
+ WI.TimelineTabContentView.Type,
+ WI.StorageTabContentView.Type,
+ WI.CanvasTabContentView.Type,
+ WI.ConsoleTabContentView.Type,
+ ]);
this._selectedTabIndexSetting = new WI.Setting("selected-tab-index", 0);
// State.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (238499 => 238500)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-11-26 18:15:18 UTC (rev 238499)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2018-11-26 18:20:55 UTC (rev 238500)
@@ -247,11 +247,13 @@
experimentalSettingsView.addSeparator();
}
+ let layerTabEnabled = window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value;
if (window.LayerTreeAgent) {
experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
experimentalSettingsView.addSeparator();
}
+ let auditTabEnabled = WI.settings.experimentalEnableAuditTab.value;
experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab"));
experimentalSettingsView.addSeparator();
@@ -260,8 +262,18 @@
let reloadInspectorButton = document.createElement("button");
reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
- reloadInspectorButton.addEventListener("click", () => { InspectorFrontendHost.reopen(); });
+ reloadInspectorButton.addEventListener("click", (event) => {
+ // Force a copy so that WI.Setting sees it as a new value.
+ let newTabs = WI._openTabsSetting.value.slice();
+ if (!layerTabEnabled && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
+ newTabs.push(WI.LayersTabContentView.Type);
+ if (!auditTabEnabled && WI.settings.experimentalEnableAuditTab.value)
+ newTabs.push(WI.AuditTabContentView.Type);
+ WI._openTabsSetting.value = newTabs;
+ InspectorFrontendHost.reopen();
+ });
+
let reloadInspectorContainerElement = experimentalSettingsView.addCenteredContainer(reloadInspectorButton, WI.UIString("for changes to take effect"));
reloadInspectorContainerElement.classList.add("hidden");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
