Diff
Modified: trunk/Source/WebCore/ChangeLog (238500 => 238501)
--- trunk/Source/WebCore/ChangeLog 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/ChangeLog 2018-11-26 18:26:48 UTC (rev 238501)
@@ -1,3 +1,26 @@
+2018-11-26 Brent Fulgham <[email protected]>
+
+ [Win] Reduce the use of WKSI library calls: CoreAnimation
+ https://bugs.webkit.org/show_bug.cgi?id=191777
+ <rdar://problem/46140542>
+
+ Reviewed by Zalan Bujtas.
+
+ Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
+ Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
+ directives for WebKitSystemInterface.lib.
+
+ No new tests. No change in behavior.
+
+ * platform/graphics/BitmapImage.cpp:
+ * platform/graphics/ca/win/CACFLayerTreeHost.h:
+ * platform/graphics/ca/win/PlatformCALayerWin.cpp:
+ (layerTreeHostForLayer):
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ * platform/graphics/cg/PathCG.cpp:
+ * platform/graphics/cg/PatternCG.cpp:
+ * platform/graphics/win/WKCAImageQueue.cpp:
+
2018-11-25 Zalan Bujtas <[email protected]>
[LFC][IFC] Use float box's margin box to adjust the line constraints.
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -38,9 +38,6 @@
#include <wtf/Vector.h>
#include <wtf/text/TextStream.h>
#include <wtf/text/WTFString.h>
-#if USE(CG) && PLATFORM(WIN)
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
-#endif
namespace WebCore {
Modified: trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h 2018-11-26 18:26:48 UTC (rev 238501)
@@ -40,7 +40,6 @@
#include <CoreGraphics/CGGeometry.h>
interface IDirect3DDevice9;
-struct WKCACFContext;
typedef struct CGImage* CGImageRef;
Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -39,7 +39,6 @@
#include "TileController.h"
#include "WebTiledBackingLayerWin.h"
#include <QuartzCore/CoreAnimationCF.h>
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
#include <wtf/text/CString.h>
#include <wtf/text/StringBuilder.h>
@@ -73,7 +72,10 @@
static AbstractCACFLayerTreeHost* layerTreeHostForLayer(const PlatformCALayer* layer)
{
// We need the AbstractCACFLayerTreeHost associated with this layer, which is stored in the UserData of the CACFContext
- void* userData = wkCACFLayerGetContextUserData(layer->platformLayer());
+ void* userData = nullptr;
+ if (CACFContextRef context = CACFLayerGetContext(layer->platformLayer()))
+ userData = CACFContextGetUserData(context);
+
if (!userData)
return nullptr;
Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -47,10 +47,6 @@
#include <wtf/RetainPtr.h>
#include <wtf/text/TextStream.h>
-#if PLATFORM(WIN)
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
-#endif
-
#define USE_DRAW_PATH_DIRECT (PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400))
// FIXME: The following using declaration should be in <wtf/HashFunctions.h>.
Modified: trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -39,10 +39,6 @@
#include <wtf/RetainPtr.h>
#include <wtf/text/WTFString.h>
-#if PLATFORM(WIN)
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
-#endif
-
namespace WebCore {
static size_t putBytesNowhere(void*, const void*, size_t count)
Modified: trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/cg/PatternCG.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -35,10 +35,6 @@
#include <pal/spi/cg/CoreGraphicsSPI.h>
#include <wtf/MainThread.h>
-#if PLATFORM(WIN)
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
-#endif
-
namespace WebCore {
static void patternCallback(void* info, CGContextRef context)
Modified: trunk/Source/WebCore/platform/graphics/win/WKCAImageQueue.cpp (238500 => 238501)
--- trunk/Source/WebCore/platform/graphics/win/WKCAImageQueue.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebCore/platform/graphics/win/WKCAImageQueue.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -27,7 +27,6 @@
#include "WKCAImageQueue.h"
#include <CoreFoundation/CoreFoundation.h>
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
#include <wtf/RetainPtr.h>
namespace WebCore {
Modified: trunk/Source/WebKitLegacy/ChangeLog (238500 => 238501)
--- trunk/Source/WebKitLegacy/ChangeLog 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/ChangeLog 2018-11-26 18:26:48 UTC (rev 238501)
@@ -1,3 +1,17 @@
+2018-11-26 Brent Fulgham <[email protected]>
+
+ [Win] Reduce the use of WKSI library calls: CoreAnimation
+ https://bugs.webkit.org/show_bug.cgi?id=191777
+ <rdar://problem/46140542>
+
+ Reviewed by Zalan Bujtas.
+
+ Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
+ Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
+ directives for WebKitSystemInterface.lib.
+
+ * PlatformWin.cmake:
+
2018-11-17 Devin Rousso <[email protected]>
Web Inspector: Network: add button to show system certificate dialog
Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (238500 => 238501)
--- trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-11-26 18:26:48 UTC (rev 238501)
@@ -24,7 +24,6 @@
PRIVATE CoreGraphics${DEBUG_SUFFIX}
PRIVATE CoreText${DEBUG_SUFFIX}
PRIVATE QuartzCore${DEBUG_SUFFIX}
- PRIVATE WebKitSystemInterface${DEBUG_SUFFIX}
PRIVATE libdispatch${DEBUG_SUFFIX}
PRIVATE libicuin${DEBUG_SUFFIX}
PRIVATE libicuuc${DEBUG_SUFFIX}
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (238500 => 238501)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-26 18:26:48 UTC (rev 238501)
@@ -1,3 +1,19 @@
+2018-11-26 Brent Fulgham <[email protected]>
+
+ [Win] Reduce the use of WKSI library calls: CoreAnimation
+ https://bugs.webkit.org/show_bug.cgi?id=191777
+ <rdar://problem/46140542>
+
+ Reviewed by Zalan Bujtas.
+
+ Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
+ Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
+ directives for WebKitSystemInterface.lib.
+
+ * FullscreenVideoController.cpp:
+ * WebKitGraphics.cpp:
+ * WebPreferences.cpp:
+
2018-11-22 Wenson Hsieh <[email protected]>
Address post-review feedback after r238438
Modified: trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp (238500 => 238501)
--- trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/win/FullscreenVideoController.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -39,7 +39,6 @@
#include <WebCore/HWndDC.h>
#include <WebCore/Page.h>
#include <WebCore/TextRun.h>
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
#include <windowsx.h>
#include <wtf/StdLibExtras.h>
Modified: trunk/Source/WebKitLegacy/win/WebKitGraphics.cpp (238500 => 238501)
--- trunk/Source/WebKitLegacy/win/WebKitGraphics.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/win/WebKitGraphics.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -42,8 +42,6 @@
#include <CoreGraphics/CoreGraphics.h>
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
-
using namespace WebCore;
static FontCascade makeFont(const WebFontDescription& description)
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (238500 => 238501)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-11-26 18:26:48 UTC (rev 238501)
@@ -33,7 +33,6 @@
#if USE(CG)
#include <CoreGraphics/CoreGraphics.h>
#include <WebCore/CACFLayerTreeHost.h>
-#include <WebKitSystemInterface/WebKitSystemInterface.h>
#endif
#include <CoreFoundation/CoreFoundation.h>
Modified: trunk/Tools/ChangeLog (238500 => 238501)
--- trunk/Tools/ChangeLog 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Tools/ChangeLog 2018-11-26 18:26:48 UTC (rev 238501)
@@ -1,3 +1,17 @@
+2018-11-26 Brent Fulgham <[email protected]>
+
+ [Win] Reduce the use of WKSI library calls: CoreAnimation
+ https://bugs.webkit.org/show_bug.cgi?id=191777
+ <rdar://problem/46140542>
+
+ Reviewed by Zalan Bujtas.
+
+ Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
+ Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
+ directives for WebKitSystemInterface.lib.
+
+ * TestWebKitAPI/PlatformWin.cmake:
+
2018-11-25 Zalan Bujtas <[email protected]>
[LFC][IFC] Use float box's margin box to adjust the line constraints.
Modified: trunk/Tools/TestWebKitAPI/PlatformWin.cmake (238500 => 238501)
--- trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2018-11-26 18:20:55 UTC (rev 238500)
+++ trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2018-11-26 18:26:48 UTC (rev 238501)
@@ -86,7 +86,6 @@
CoreGraphics${DEBUG_SUFFIX}
CoreText${DEBUG_SUFFIX}
QuartzCore${DEBUG_SUFFIX}
- WebKitSystemInterface${DEBUG_SUFFIX}
WebKitQuartzCoreAdditions${DEBUG_SUFFIX}
libdispatch${DEBUG_SUFFIX}
libexslt${DEBUG_SUFFIX}
