Title: [240338] trunk/Source/WebKit
- Revision
- 240338
- Author
- [email protected]
- Date
- 2019-01-23 08:48:04 -0800 (Wed, 23 Jan 2019)
Log Message
[GTK] Crash when browsing inspector:// uri without port set
https://bugs.webkit.org/show_bug.cgi?id=193721
Reviewed by Michael Catanzaro.
* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::handleRequest): Return
back to caller after setting the error, if no port was provided
along with the inspector URL.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (240337 => 240338)
--- trunk/Source/WebKit/ChangeLog 2019-01-23 16:29:53 UTC (rev 240337)
+++ trunk/Source/WebKit/ChangeLog 2019-01-23 16:48:04 UTC (rev 240338)
@@ -1,3 +1,15 @@
+2019-01-23 Philippe Normand <[email protected]>
+
+ [GTK] Crash when browsing inspector:// uri without port set
+ https://bugs.webkit.org/show_bug.cgi?id=193721
+
+ Reviewed by Michael Catanzaro.
+
+ * UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
+ (WebKit::RemoteInspectorProtocolHandler::handleRequest): Return
+ back to caller after setting the error, if no port was provided
+ along with the inspector URL.
+
2019-01-23 David Kilzer <[email protected]>
Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp (240337 => 240338)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2019-01-23 16:29:53 UTC (rev 240337)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2019-01-23 16:48:04 UTC (rev 240338)
@@ -92,6 +92,7 @@
if (!requestURL.port()) {
GUniquePtr<GError> error(g_error_new_literal(WEBKIT_POLICY_ERROR, WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI, "Cannot show inspector URL: no port provided"));
webkit_uri_scheme_request_finish_error(request, error.get());
+ return;
}
auto* webView = webkit_uri_scheme_request_get_web_view(request);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
