Title: [240339] trunk/Tools
Revision
240339
Author
[email protected]
Date
2019-01-23 09:23:29 -0800 (Wed, 23 Jan 2019)

Log Message

webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
https://bugs.webkit.org/show_bug.cgi?id=193722
<rdar://problem/47481475>

Reviewed by Lucas Forschler.

iPhone and iPad ports should both use the iOS config.

* Scripts/webkitpy/port/ios_simulator.py:
(IPhoneSimulatorPort.__init__):
(IPadSimulatorPort.__init__):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (240338 => 240339)


--- trunk/Tools/ChangeLog	2019-01-23 16:48:04 UTC (rev 240338)
+++ trunk/Tools/ChangeLog	2019-01-23 17:23:29 UTC (rev 240339)
@@ -1,3 +1,17 @@
+2019-01-23  Jonathan Bedard  <[email protected]>
+
+        webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
+        https://bugs.webkit.org/show_bug.cgi?id=193722
+        <rdar://problem/47481475>
+
+        Reviewed by Lucas Forschler.
+
+        iPhone and iPad ports should both use the iOS config.
+
+        * Scripts/webkitpy/port/ios_simulator.py:
+        (IPhoneSimulatorPort.__init__):
+        (IPadSimulatorPort.__init__):
+
 2019-01-23  Rob Buis  <[email protected]>
 
         Update MIME type parser

Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (240338 => 240339)


--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py	2019-01-23 16:48:04 UTC (rev 240338)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py	2019-01-23 17:23:29 UTC (rev 240339)
@@ -24,7 +24,7 @@
 
 from webkitpy.common.memoized import memoized
 from webkitpy.common.version import Version
-from webkitpy.port.config import apple_additions
+from webkitpy.port.config import apple_additions, Config
 from webkitpy.port.ios import IOSPort
 from webkitpy.xcode.device_type import DeviceType
 from webkitpy.xcode.simulated_device import SimulatedDeviceManager
@@ -120,9 +120,17 @@
         DeviceType(hardware_family='iPhone', hardware_type='7'),
     ]
 
+    def __init__(self, *args, **kwargs):
+        super(IPhoneSimulatorPort, self).__init__(*args, **kwargs)
+        self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name)
 
+
 class IPadSimulatorPort(IOSSimulatorPort):
     port_name = 'ipad-simulator'
 
     DEVICE_TYPE = DeviceType(hardware_family='iPad')
     DEFAULT_DEVICE_TYPES = [DeviceType(hardware_family='iPad', hardware_type='(5th generation)')]
+
+    def __init__(self, *args, **kwargs):
+        super(IPadSimulatorPort, self).__init__(*args, **kwargs)
+        self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to