Title: [240647] trunk/Source/WebInspectorUI
- Revision
- 240647
- Author
- [email protected]
- Date
- 2019-01-28 23:55:42 -0800 (Mon, 28 Jan 2019)
Log Message
Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler
https://bugs.webkit.org/show_bug.cgi?id=193921
Patch by Joseph Pecoraro <[email protected]> on 2019-01-28
Reviewed by Devin Rousso.
* UserInterface/Base/Utilities.js:
* UserInterface/Debug/UncaughtExceptionReporter.js:
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._exportHAR):
* UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.updateFormattedState):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240646 => 240647)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-29 07:15:00 UTC (rev 240646)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-29 07:55:42 UTC (rev 240647)
@@ -1,3 +1,17 @@
+2019-01-28 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler
+ https://bugs.webkit.org/show_bug.cgi?id=193921
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Utilities.js:
+ * UserInterface/Debug/UncaughtExceptionReporter.js:
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView.prototype._exportHAR):
+ * UserInterface/Views/TextEditor.js:
+ (WI.TextEditor.prototype.updateFormattedState):
+
2019-01-28 Devin Rousso <[email protected]>
Web Inspector: provide a way to edit page WebRTC settings on a remote target
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (240646 => 240647)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2019-01-29 07:15:00 UTC (rev 240646)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2019-01-29 07:55:42 UTC (rev 240647)
@@ -1769,10 +1769,3 @@
fileReader.addEventListener("loadend", () => { callback(fileReader.result); });
fileReader.readAsText(blob);
}
-
-if (!window.handlePromiseException) {
- window.handlePromiseException = function handlePromiseException(error)
- {
- console.error("Uncaught exception in Promise", error);
- };
-}
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js (240646 => 240647)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2019-01-29 07:15:00 UTC (rev 240646)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2019-01-29 07:55:42 UTC (rev 240647)
@@ -299,6 +299,6 @@
window.addEventListener("error", handleUncaughtException);
window.addEventListener("unhandledrejection", handleUnhandledPromiseRejection);
-window.handlePromiseException = window.handleInternalException = handleError;
+window.handleInternalException = handleError;
})();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (240646 => 240647)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-29 07:15:00 UTC (rev 240646)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2019-01-29 07:55:42 UTC (rev 240647)
@@ -1923,7 +1923,7 @@
content: JSON.stringify(har, null, 2),
forceSaveAs: true,
});
- }).catch(handlePromiseException);
+ });
}
_waterfallPopoverContent()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (240646 => 240647)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2019-01-29 07:15:00 UTC (rev 240646)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2019-01-29 07:55:42 UTC (rev 240647)
@@ -200,7 +200,7 @@
updateFormattedState(formatted)
{
- return this._format(formatted).catch(handlePromiseException);
+ return this._format(formatted);
}
hasFormatter()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
